Open
Conversation
zepfred
commented
Feb 20, 2026
tools/migration/src/main/resources/META-INF/rewrite/ToLatest.yml
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an automated migration recipe for the score class restructuring in Timefold Solver 2.0.0. The migration moves score classes from the buildin subpackages to the top-level score package, and consolidates Long-based variants into their base types.
Changes:
- Added
ScoreClassesMigrationRecipeto automate migration from deprecated score class locations to new package structure - Added comprehensive test coverage for the migration recipe
- Integrated the recipe into the
ToLatestmigration workflow with automatic import cleanup - Removed reference to non-existent
FromOptaPlannerToTimefoldSolverrecipe
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/migration/src/main/java/ai/timefold/solver/migration/ScoreClassesMigrationRecipe.java | Implements migration recipe that transforms 12 score class types from buildin subpackages to top-level score package, consolidating Long variants into base types |
| tools/migration/src/test/java/ai/timefold/solver/migration/ScoreClassesMigrationRecipeTest.java | Adds test validating that all score types are correctly migrated with proper import statements |
| tools/migration/src/main/resources/META-INF/rewrite/ToLatest.yml | Integrates new score class migration recipe into migration workflow and removes reference to non-existent recipe |
Comments suppressed due to low confidence (1)
tools/migration/src/main/resources/META-INF/rewrite/ToLatest.yml:6
- The removal of 'ai.timefold.solver.migration.FromOptaPlannerToTimefoldSolver' from the recipe list is not mentioned in the PR title or description. This recipe does not exist in the current codebase, suggesting it may have been a placeholder or leftover reference. However, if this recipe was intentionally present for a reason (even if not yet implemented), removing it without explanation could be a mistake. Consider documenting this removal in the PR description.
- org.openrewrite.properties.ChangePropertyKey:
triceo
reviewed
Feb 20, 2026
...s/migration/src/main/java/ai/timefold/solver/migration/GeneralChangeTypeMigrationRecipe.java
Show resolved
Hide resolved
| "package ai.timefold.solver.core.api.score.buildin.bendablelong; public class BendableLongScore {}", | ||
| "package ai.timefold.solver.core.api.score.buildin.bendablebigdecimal; public class BendableBigDecimalScore {}", | ||
| "package ai.timefold.solver.core.api.solver; public class ProblemFactChange {}", | ||
| "package ai.timefold.solver.core.config.solver; public enum EnvironmentMode {FAST_ASSERT, REPRODUCIBLE}")); |
There was a problem hiding this comment.
The enum stub only defines FAST_ASSERT and REPRODUCIBLE, but the test expects these to be replaced with STEP_ASSERT and NO_ASSERT which are not defined in the stub. Add STEP_ASSERT and NO_ASSERT to the enum stub so OpenRewrite can properly resolve the target constants during migration.
Suggested change
| "package ai.timefold.solver.core.config.solver; public enum EnvironmentMode {FAST_ASSERT, REPRODUCIBLE}")); | |
| "package ai.timefold.solver.core.config.solver; public enum EnvironmentMode {FAST_ASSERT, STEP_ASSERT, NO_ASSERT, REPRODUCIBLE}")); |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.