refactor: ScoreDirector is no longer public

[triceo]

No description provided.

[Copilot]

Pull request overview

This pull request refactors the ScoreDirector from public API to internal implementation as part of Timefold Solver 2.0. The changes involve moving ScoreDirector from ai.timefold.solver.core.api.score.director to ai.timefold.solver.core.impl.score.director, and introducing a new PhaseCommandContext interface to replace the direct use of ScoreDirector in the public API. This is a significant breaking change that improves API encapsulation.

Changes:

• ScoreDirector moved from public API to internal implementation package
• PhaseCommand interface refactored to use PhaseCommandContext instead of ScoreDirector and BooleanSupplier parameters
• SolutionPartitioner.splitWorkingSolution() signature changed to accept Solution_ instead of ScoreDirector<Solution_>
• Documentation updated to reflect new API patterns and remove deprecated content
• Test domain classes updated (comparator/factory naming consistency improvements)
• MoveDirector enhanced with new assignValuesAndAdd method and executeTemporary variants

Reviewed changes

Copilot reviewed 123 out of 123 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
core/src/main/java/ai/timefold/solver/core/impl/score/director/ScoreDirector.java	Moved from api package to impl package, marked as non-public API
core/src/main/java/ai/timefold/solver/core/api/solver/phase/PhaseCommand.java	Interface refactored to use PhaseCommandContext parameter
core/src/main/java/ai/timefold/solver/core/api/solver/phase/PhaseCommandContext.java	New interface providing access to working solution and move execution
core/src/main/java/ai/timefold/solver/core/impl/phase/custom/DefaultPhaseCommandContext.java	Implementation of PhaseCommandContext
core/src/main/java/ai/timefold/solver/core/impl/partitionedsearch/partitioner/SolutionPartitioner.java	Interface updated to remove ScoreDirector dependency
core/src/main/java/ai/timefold/solver/core/impl/move/MoveDirector.java	Enhanced with new assignValuesAndAdd method and executeTemporary variants
docs/src/modules/ROOT/pages/optimization-algorithms/overview.adoc	Updated PhaseCommand documentation with new API
docs/src/modules/ROOT/pages/responding-to-change/responding-to-change.adoc	Removed deprecated PinningFilter section, updated ProblemChange references
docs/src/modules/ROOT/pages/constraints-and-score/constraint-configuration.adoc	Removed deprecated constraint configuration section
Multiple test files	Updated PhaseCommand implementations to use new API, comparator/factory naming improvements
Multiple impl files	Updated imports from api.score.director to impl.score.director

[Copilot]

Pull request overview

Copilot reviewed 166 out of 166 changed files in this pull request and generated 2 comments.

[Christopher-Chianelli]

I dislike renaming Rebaser to Lookup; the methods are more awkward, and I believe some changes should be made; in particular, the lookup/rebase method should not have "return null if does not exist" method, and instead I propose these two methods:

@NullMarked
interface Rebaser {
    @Nullable
    <Type_> rebase(@Nullable Type_ toRebase);
    <Type_> rebaseExisting(Type_ toRebase);
}

Both methods fail fast if toRebase does not exist in the ScoreDirector. They only differ in one accepts null (and thus return a nullable), the other does not (and thus always return non-null).

[Copilot]

Pull request overview

Copilot reviewed 165 out of 165 changed files in this pull request and generated no new comments.

[Christopher-Chianelli]

I strongly disagree with erroring on unamed package; it forces the user to put classes inside a package, making it unsuitable for defining classes in a scripting context (such as jshell). Why does this matter to us? Rest of changes LGTM.

[Copilot]

Pull request overview

Copilot reviewed 170 out of 170 changed files in this pull request and generated no new comments.

[sonarqubecloud]

Quality Gate passed

Issues
32 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud