chore: fail-fast validation for invalid value ranges #2069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zepfred
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request implements fail-fast validation for invalid value ranges to catch configuration errors early when planning values are assigned outside their defined value ranges.
Changes:
- Added value range validation that checks all assigned planning values are within their respective value ranges
- Validation runs once at solver initialization and optionally during move execution in FULL_ASSERT mode
- Comprehensive test coverage for basic variables, list variables, multi-variable entities, and custom phases
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| core/src/main/java/ai/timefold/solver/core/impl/score/director/InnerScoreDirector.java | Added interface method for value range assertion |
| core/src/main/java/ai/timefold/solver/core/impl/score/director/AbstractScoreDirector.java | Implemented value range validation logic for basic and list variables, integrated into move execution assertions |
| core/src/main/java/ai/timefold/solver/core/impl/solver/scope/SolverScope.java | Added one-time value range check during initial solution setup |
| core/src/main/java/ai/timefold/solver/core/impl/phase/custom/DefaultCustomPhase.java | Added value range assertion for custom phases when running in FULL_ASSERT mode |
| core/src/test/java/ai/timefold/solver/core/impl/solver/DefaultSolverTest.java | Added comprehensive tests for value range validation across different variable types and scenarios |
core/src/main/java/ai/timefold/solver/core/impl/score/director/InnerScoreDirector.java
Outdated
Show resolved
Hide resolved
core/src/main/java/ai/timefold/solver/core/impl/solver/scope/SolverScope.java
Outdated
Show resolved
Hide resolved
core/src/test/java/ai/timefold/solver/core/impl/solver/DefaultSolverTest.java
Outdated
Show resolved
Hide resolved
core/src/main/java/ai/timefold/solver/core/impl/solver/scope/SolverScope.java
Outdated
Show resolved
Hide resolved
core/src/main/java/ai/timefold/solver/core/impl/score/director/AbstractScoreDirector.java
Outdated
Show resolved
Hide resolved
triceo
reviewed
Feb 3, 2026
Collaborator
triceo
left a comment
triceo
left a comment
There was a problem hiding this comment.
Much better! IMO still room for improvement.
core/src/main/java/ai/timefold/solver/core/impl/score/director/AbstractScoreDirector.java
Outdated
Show resolved
Hide resolved
core/src/main/java/ai/timefold/solver/core/impl/score/director/AbstractScoreDirector.java
Outdated
Show resolved
Hide resolved
core/src/main/java/ai/timefold/solver/core/impl/score/director/AbstractScoreDirector.java
Outdated
Show resolved
Hide resolved
core/src/main/java/ai/timefold/solver/core/impl/score/director/AbstractScoreDirector.java
Outdated
Show resolved
Hide resolved
...a/ai/timefold/solver/core/testdomain/clone/customcloner/TestdataCorrectlyClonedSolution.java
Show resolved
Hide resolved
core/src/main/java/ai/timefold/solver/core/impl/score/director/AbstractScoreDirector.java
Outdated
Show resolved
Hide resolved
core/src/main/java/ai/timefold/solver/core/impl/score/director/AbstractScoreDirector.java
Outdated
Show resolved
Hide resolved
core/src/main/java/ai/timefold/solver/core/impl/score/director/AbstractScoreDirector.java
Show resolved
Hide resolved
Collaborator
|
Having just merged my other PR, this one now has conflicts. :-( |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.