fix: in unity_malloc (unity_memory in unity_memory.c#832
Open
orbisai0security wants to merge 1 commit into
Open
fix: in unity_malloc (unity_memory in unity_memory.c#832orbisai0security wants to merge 1 commit into
orbisai0security wants to merge 1 commit into
Conversation
Automated security fix generated by Orbis Security AI Signed-off-by: orbisai0security <mediratta01.pally@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
extras/memory/src/unity_memory.c.Vulnerability
V-001extras/memory/src/unity_memory.c:96Description: In unity_malloc (unity_memory.c:96-103), UNITY_MALLOC allocates total_size bytes for a Guard structure plus user data. The memcpy at line 103 writes a guard pattern to &mem[size] without verifying that size + sizeof(end) does not exceed total_size. If total_size overflows during calculation or size is otherwise incorrect, &mem[size] points beyond the allocated heap region, causing a heap buffer overflow. In unity_realloc (line 200), memcpy(newMem, oldMem, guard->size) copies guard->size bytes into the new allocation without verifying guard->size does not exceed the new allocation's capacity, enabling a second heap overflow path.
Changes
extras/memory/src/unity_memory.cVerification
Automated security fix by OrbisAI Security