Skip to content

fix where condition priority#58

Open
xiluoduyu wants to merge 1 commit intoThreeDotsLabs:masterfrom
xiluoduyu:patch-1
Open

fix where condition priority#58
xiluoduyu wants to merge 1 commit intoThreeDotsLabs:masterfrom
xiluoduyu:patch-1

Conversation

@xiluoduyu
Copy link
Copy Markdown

When where is "delayed_until <= UTC_TIMESTAMP() OR delayed_until IS NULL", tasks with NULL delayed_until will be repeatly executed, acked=1 wont work: WHERE acked = false AND delayed_until <= UTC_TIMESTAMP() OR delayed_until IS NULL

Motivation / Background

Details

Alternative approaches considered (if applicable)

Checklist

The resources of our team are limited. There are a couple of things that you can do to help us merge your PR faster:

  • I wrote tests for the changes.
  • All tests are passing.
    • If you are testing a Pub/Sub, you can start Docker with make up.
    • You can start with make test_short for a quick check.
    • If you want to run all tests, use make test.
  • Code has no breaking changes.
  • (If applicable) documentation on watermill.io is updated.

When where is "delayed_until <= UTC_TIMESTAMP() OR delayed_until IS NULL",  tasks with NULL delayed_until will be repeatly executed, acked=1 wont work:  WHERE acked = false AND delayed_until <= UTC_TIMESTAMP() OR delayed_until IS NULL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant