Prevent blank PDF exports for large Markdown documents by bounding html2canvas render scale#65
Draft
Prevent blank PDF exports for large Markdown documents by bounding html2canvas render scale#65
Conversation
Agent-Logs-Url: https://github.com/ThisIs-Developer/Markdown-Viewer/sessions/d80d4d3a-e671-48a7-8411-d69ce79349a8 Co-authored-by: ThisIs-Developer <109382325+ThisIs-Developer@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ThisIs-Developer/Markdown-Viewer/sessions/d80d4d3a-e671-48a7-8411-d69ce79349a8 Co-authored-by: ThisIs-Developer <109382325+ThisIs-Developer@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ThisIs-Developer/Markdown-Viewer/sessions/d80d4d3a-e671-48a7-8411-d69ce79349a8 Co-authored-by: ThisIs-Developer <109382325+ThisIs-Developer@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ThisIs-Developer/Markdown-Viewer/sessions/d80d4d3a-e671-48a7-8411-d69ce79349a8 Co-authored-by: ThisIs-Developer <109382325+ThisIs-Developer@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ThisIs-Developer/Markdown-Viewer/sessions/d80d4d3a-e671-48a7-8411-d69ce79349a8 Co-authored-by: ThisIs-Developer <109382325+ThisIs-Developer@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ThisIs-Developer/Markdown-Viewer/sessions/d80d4d3a-e671-48a7-8411-d69ce79349a8 Co-authored-by: ThisIs-Developer <109382325+ThisIs-Developer@users.noreply.github.com>
…ml2canvas render scale Agent-Logs-Url: https://github.com/ThisIs-Developer/Markdown-Viewer/sessions/d80d4d3a-e671-48a7-8411-d69ce79349a8 Co-authored-by: ThisIs-Developer <109382325+ThisIs-Developer@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
ThisIs-Developer
April 3, 2026 09:11
View session
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large Markdown documents could produce empty PDFs because the export pipeline attempted canvas captures beyond browser-safe limits; small files continued to work because they stayed below those thresholds.
Root cause addressed: oversized canvas capture in PDF export
MAX_PDF_CANVAS_DIMENSION(per-side cap)MAX_PDF_CANVAS_AREA(total pixel cap)MIN_READABLE_PDF_SCALE(lower bound for legibility)safeScalefrom document dimensions + bounds before callinghtml2canvas, preventing blank output from failed/invalid canvas allocation.Export capture now uses actual rendered element dimensions
actualElementWidth,actualElementHeight).html2canvas(windowWidth,windowHeight) to keep pagination math and capture behavior aligned for long documents.Maintainability improvements in PDF export path