-
Notifications
You must be signed in to change notification settings - Fork 47
Enable single-dollar inline LaTeX rendering in MathJax #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -45,15 +45,25 @@ | |||||||||||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/dompurify/3.0.9/purify.min.js"></script> | ||||||||||||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/FileSaver.js/2.0.5/FileSaver.min.js"></script> | ||||||||||||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/html2pdf.js/0.10.1/html2pdf.bundle.min.js"></script> | ||||||||||||
| <script> | ||||||||||||
| window.MathJax = { | ||||||||||||
| tex: { | ||||||||||||
| inlineMath: [['$', '$'], ['\\(', '\\)']], | ||||||||||||
| displayMath: [['$$', '$$'], ['\\[', '\\]']], | ||||||||||||
| processEscapes: true | ||||||||||||
| } | ||||||||||||
| }; | ||||||||||||
| </script> | ||||||||||||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/mathjax/3.2.2/es5/tex-mml-chtml.min.js"></script> | ||||||||||||
| <script src="https://cdn.jsdelivr.net/npm/mermaid@11.6.0/dist/mermaid.min.js"></script> | ||||||||||||
| <script src="https://cdn.jsdelivr.net/npm/emoji-toolkit@9.0.1/lib/js/joypixels.min.js"></script> | ||||||||||||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/jspdf/2.5.1/jspdf.umd.min.js"></script> | ||||||||||||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/html2canvas/1.4.1/html2canvas.min.js"></script> | ||||||||||||
|
|
||||||||||||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/pdfmake/0.2.7/pdfmake.min.js"></script> | ||||||||||||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/pdfmake/0.2.7/vfs_fonts.js"></script> | ||||||||||||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/pako/2.1.0/pako.min.js" integrity="sha384-rNlaE5fs9dGIjmxWDALQh/RBAaGRYT5ChrzHo6tRfgrZ36iRFAiquP5g41Jsv+0j" crossorigin="anonymous"></script> | ||||||||||||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/pdfmake/0.2.7/pdfmake.min.js"></script> | ||||||||||||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/pdfmake/0.2.7/vfs_fonts.js"></script> | ||||||||||||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/pako/2.1.0/pako.min.js" integrity="sha384-rNlaE5fs9dGIjmxWDALQh/RBAaGRYT5ChrzHo6tRfgrZ36iRFAiquP5g41Jsv+0j" crossorigin="anonymous"></script> | ||||||||||||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/js-yaml/4.1.0/js-yaml.min.js"></script> | ||||||||||||
| </head> | ||||||||||||
| <body> | ||||||||||||
| <div class="app-container"> | ||||||||||||
|
|
@@ -276,6 +286,11 @@ <h5>Menu</h5> | |||||||||||
| <p id="github-import-title" class="reset-modal-message">Import Markdown from GitHub</p> | ||||||||||||
| <input type="url" id="github-import-url" class="rename-modal-input" placeholder="https://github.com/owner/repo/blob/main/README.md" /> | ||||||||||||
| <select id="github-import-file-select" class="rename-modal-input" style="display:none;"></select> | ||||||||||||
| <div id="github-import-selection-toolbar" class="github-import-selection-toolbar" style="display:none;"> | ||||||||||||
| <span id="github-import-selected-count" class="github-import-selected-count">0 selected</span> | ||||||||||||
| <button type="button" class="reset-modal-btn" id="github-import-select-all">Select All</button> | ||||||||||||
| </div> | ||||||||||||
| <div id="github-import-tree" class="github-import-tree" style="display:none;"></div> | ||||||||||||
|
Comment on lines
+289
to
+293
|
||||||||||||
| <div id="github-import-selection-toolbar" class="github-import-selection-toolbar" style="display:none;"> | |
| <span id="github-import-selected-count" class="github-import-selected-count">0 selected</span> | |
| <button type="button" class="reset-modal-btn" id="github-import-select-all">Select All</button> | |
| </div> | |
| <div id="github-import-tree" class="github-import-tree" style="display:none;"></div> |
Copilot
AI
Apr 2, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description is scoped to MathJax delimiter configuration, but this hunk also changes the GitHub import modal UI (selection toolbar + file tree) for the desktop app. Please confirm this is intentional and update the PR description (or split into a separate PR) so reviewers understand the additional behavior/UI change being shipped.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
js-yamlis newly loaded here, but the desktop bundle (desktop-app/resources/js/script.jsandmain.js) doesn’t reference thejsyamlglobal. If it’s not needed on desktop, consider removing this script tag to avoid an extra CDN dependency and unnecessary load time; if it is needed, add/verify the corresponding usage so this include is justified.