fix(renderer): stabilize markdown scrollbars#1773
Conversation
02f5d2a to
bef9149
Compare
📝 WalkthroughWalkthroughAdds two CSS/config changes to ChangesScrollbar Jitter Fix
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
docs/issues/markdown-codeblock-scrollbar-jitter/plan.md (1)
73-77: 💤 Low valueOptional: Consider rewording repeated sentence beginnings.
Lines 73–77 begin successive sentences with "Do not", which LanguageTool flags as repetitive style. Consider varying sentence structure for improved readability (e.g., "Avoid patching..., prefer CSS overrides..., refrain from forcing..."). This is a minor improvement and can be deferred.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/issues/markdown-codeblock-scrollbar-jitter/plan.md` around lines 73 - 77, In the bulleted list on lines 73-77 of the plan.md file, replace the repetitive "Do not" sentence starters with varied phrases to improve readability. Reword each bullet point to use different opening phrases such as "Avoid", "Prefer", "Refrain from", or similar alternatives while maintaining the same meaning and context of the original statements.Source: Linters/SAST tools
docs/issues/markdown-codeblock-scrollbar-jitter/spec.md (1)
73-77: 💤 Low valueOptional: Consider rewording repeated sentence beginnings.
Lines 73–77 begin successive sentences with "Do not / Prefer / Do not / Do not / Do not", which LanguageTool flags as repetitive style. Consider varying the sentence structure or using synonyms for clarity (e.g., "Avoid patching... / Consider CSS overrides instead... / Refrain from forcing..."). This is a minor readability improvement and can be deferred.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/issues/markdown-codeblock-scrollbar-jitter/spec.md` around lines 73 - 77, The specification in spec.md at lines 73-77 contains repetitive sentence beginnings with multiple consecutive sentences starting with "Do not" or similar phrasing, which impacts readability. Rephrase these sentences to vary the sentence structure and use alternative synonyms such as "Avoid", "Refrain from", "Consider using", or restructure them to begin with different parts of speech or clause types, ensuring the technical meaning and requirements remain clear while improving the overall flow and readability of the specification.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@docs/issues/markdown-codeblock-scrollbar-jitter/plan.md`:
- Around line 73-77: In the bulleted list on lines 73-77 of the plan.md file,
replace the repetitive "Do not" sentence starters with varied phrases to improve
readability. Reword each bullet point to use different opening phrases such as
"Avoid", "Prefer", "Refrain from", or similar alternatives while maintaining the
same meaning and context of the original statements.
In `@docs/issues/markdown-codeblock-scrollbar-jitter/spec.md`:
- Around line 73-77: The specification in spec.md at lines 73-77 contains
repetitive sentence beginnings with multiple consecutive sentences starting with
"Do not" or similar phrasing, which impacts readability. Rephrase these
sentences to vary the sentence structure and use alternative synonyms such as
"Avoid", "Refrain from", "Consider using", or restructure them to begin with
different parts of speech or clause types, ensuring the technical meaning and
requirements remain clear while improving the overall flow and readability of
the specification.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: c7cd8fbe-1dd5-4c33-98cc-bac5bfe9ade0
📒 Files selected for processing (5)
docs/issues/markdown-codeblock-scrollbar-jitter/plan.mddocs/issues/markdown-codeblock-scrollbar-jitter/spec.mddocs/issues/markdown-codeblock-scrollbar-jitter/tasks.mdsrc/renderer/src/components/markdown/MarkdownRenderer.vuetest/renderer/components/MarkdownRenderer.test.ts
Summary
wordWrap: 'on'.Testing
pnpm run formatpnpm run i18npnpm run lintpnpm run typecheckpnpm test:renderer -- test/renderer/components/MarkdownRenderer.test.tsManual Verification
Closes #1763
Summary by CodeRabbit
Bug Fixes
New Features
Tests
Documentation