bugfix(money): Fix undefined behavior for starting cash combo box

[Caball009]

Players that modify their GlobalData::m_defaultStartingCash value may see strange behavior when it comes to their starting cash (skirmish and multiplayer). That's because the game dereferences an end iterator if it cannot find one of the four default starting cash values. This crashes the game in debug builds and it may produce 'random' starting cash values in release builds. (Even though the starting cash is unsigned, the visual amount may show up as negative in the control bar).

TODO:

• Replicate in Generals.

[greptile-apps]

Greptile Summary

This PR fixes undefined behavior in PopulateStartingCashComboBox (Zero Hour / GeneralsMD) where the post-loop it iterator — pointing to end() — was dereferenced to retrieve item data for a custom starting-cash value not present in the standard list. The fix replaces it->countMoney() with myGame->getStartingCash().countMoney() in the fallback branch and scopes it inside the for loop to prevent the same mistake in future edits. It also removes a stale declaration of the same function from the vanilla Generals header, where no corresponding definition ever existed.

Confidence Score: 5/5

Safe to merge — the fix is minimal, targeted, and correct.

The only changed logic replaces an end-iterator dereference (definite UB) with the semantically correct value from myGame. The orphaned header declaration removal is pure cleanup with no behavioral impact. No new issues introduced.

No files require special attention.

Important Files Changed

Filename	Overview
GeneralsMD/Code/GameEngine/Source/GameNetwork/GUIUtil.cpp	Fixes UB caused by dereferencing the end iterator after the loop; also tightens it's scope to the loop itself.
Generals/Code/GameEngine/Include/GameNetwork/GUIUtil.h	Removes orphaned declaration of PopulateStartingCashComboBox, which was never defined in the vanilla Generals code tree.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PopulateStartingCashComboBox called] --> B[Reset combo box]
    B --> C[Iterate over startingCashMap]
    C --> D{amountEqual current cash?}
    D -- Yes --> E[Set currentSelectionIndex = newIndex]
    D -- No --> C
    C -- Loop ends --> F{currentSelectionIndex == -1?}
    E --> F
    F -- No --> G[GadgetComboBoxSetSelectedPos]
    F -- Yes --> H[DEBUG_CRASH]
    H --> I[Add custom entry to combo box]
    I --> J["Set item data: myGame->getStartingCash().countMoney() ✅ (was: it->countMoney() on end iterator ❌)"]
    J --> G

Loading

_{Reviews (2): Last reviewed commit: "Removed unused function declaration in G..." | Re-trigger Greptile}

[Caball009]

Updated PR.

It looks like PopulateStartingCashComboBox doesn't exist in Generals, only the unused function declaration, which I removed.

[xezon]

This may be here because we already merged code from Zero Hour to Generals. You can keep it.