fix(ini): Support plus sign character prefix in INI integer parse

[xezon]

• Closes fix(ini): Handle leading '+' sign in std::from_chars parsing #2548

Alternative fix to #2548

Omits empty test because a token is implicitly not empty.

This change was not required for the original INI files.

Tested and worked.

[greptile-apps]

Greptile Summary

Adds support for +-prefixed integers (and floats) in the std::from_chars-based INI parser by stripping the leading + before calling from_chars, which mirrors sscanf behaviour. As a secondary fix, the intermediate result type for non-integral template instantiations is corrected from the hard-coded Real to the template parameter Type, making the helper properly generic.

Confidence Score: 5/5

Safe to merge — the change is minimal, correct, and all edge cases are handled appropriately.

Only one file changed with a small, focused fix. Stripping the leading + before std::from_chars correctly mirrors sscanf behaviour, the bare-"+" edge case is safely rejected by from_chars returning std::errc::invalid_argument, and the secondary correction from Real to Type improves template correctness. No P0 or P1 issues found.

No files require special attention.

Important Files Changed

Filename	Overview
Core/GameEngine/Source/Common/INI/INI.cpp	Strips leading + sign before std::from_chars parsing and corrects the intermediate result type from Real to the template parameter Type; logic is sound and edge cases are all handled correctly or intentionally acknowledged.

_{Reviews (3): Last reviewed commit: "tweak assert message" | Re-trigger Greptile}

[Skyaero42]

Same as #2548, this 'fix' needs a comment on why we want to keep parsing the '+' sign

// TheSuperHackers @info std::from_chars does not support a leading '+' sign. Strip it to match // sscanf and accommodate mod makers who use explicit signed values (e.g. +20 / -20).

[xezon]

I do not think this level of detail is required for this comment. The comment already clarifies that from_chars behaves different to sscanf, and this difference is mitigated accordingly.

[Caball009]

Could add to the first post that this change is not required for the default ini files.

[xezon]

Ok did that. It is implicitly mentioned by the "Mod" label as well.

[Caball009]

nit: "token is not expected to be empty"

[xezon]

Fixed

[Caball009]

Do we care about "+" for integers? If we only care about "+" for floating point values, we could do something like:

if constexpr (std::floating_point<Type>)
{
	// Unlike sscanf, std::from_chars cannot parse "+"
	if (token[0] == '+')
	{
		token.remove_prefix(1);
	}
}

[xezon]

In INI file, integer and float are indistinguishable, so a user could add + to both and not be aware about its underlying type.

[Caball009]

Omits empty test because a token is implicitly not empty.

What's this based on? Did you check all call sites?

[xezon]

What's this based on? Did you check all call sites?

I launched the game and it did not hit the assert condition.