Skip to content

fix(pathfinder): Fix CRC computation of PathFinder::m_wallPieces #2575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xezon merged 2 commits into from
Apr 12, 2026
+12 −2
Merged

fix(pathfinder): Fix CRC computation of PathFinder::m_wallPieces #2575

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52ab020
fix(pathfinder): Fix CRC computation of PathFinder::m_wallPieces.
Caball009 Apr 10, 2026
9ed1c03
Tweaked code and comment.
Caball009 Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions Core/GameEngine/Source/GameLogic/AI/AIPathfind.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11338,10 +11338,20 @@ void Pathfinder::crc( Xfer *xfer )

xfer->xferInt(&m_numWallPieces);
CRCDEBUG_LOG(("m_numWallPieces: %8.8X", ((XferCRC *)xfer)->getCRC()));
for (Int i=0; i<MAX_WALL_PIECES; ++i)

#if RETAIL_COMPATIBLE_CRC
// TheSuperHackers @fix The original code effectively accessed m_numWallPieces 128 times,
// because it used &m_wallPieces[MAX_WALL_PIECES] which is out-of-bounds and points to m_numWallPieces.
static_assert(sizeof(Int) == sizeof(ObjectID), "Type sizes must be equal for correct xfer");

for (Int i = 0; i < MAX_WALL_PIECES; ++i)
{
xfer->xferObjectID(&m_wallPieces[MAX_WALL_PIECES]);
xfer->xferInt(&m_numWallPieces);
}
#else
xfer->xferUser(m_wallPieces, sizeof(m_wallPieces));
#endif

CRCDEBUG_LOG(("m_wallPieces: %8.8X", ((XferCRC *)xfer)->getCRC()));

xfer->xferReal(&m_wallHeight);
Expand Down
Loading