build: Fix compile error when building without RETAIL_COMPATIBLE_CRC

[xezon]

• Follow up for tweak(upgrade): Increase upgrade limit to 512 #2162

This change fixes a compile error when building without RETAIL_COMPATIBLE_CRC.

[greptile-apps]

Greptile Summary

Fixes a compile error introduced in #2162 (upgrade limit increase to 512) when building without RETAIL_COMPATIBLE_CRC. The AsciiString class uses .str() to return const char*, not .c_str() — the original code called .c_str() which does not exist on AsciiString, causing a build failure in the non-retail CRC debug logging path.

• Corrected .c_str() → .str() in Object::crc() debug logging for both Generals and GeneralsMD

Confidence Score: 5/5

• This PR is safe to merge — it's a trivial one-token fix to a compile error in a conditional compilation path.
• The change is minimal (replacing a non-existent method .c_str() with the correct .str() on AsciiString), affects only a debug logging path guarded by #ifdef DEBUG_CRC and #if !RETAIL_COMPATIBLE_CRC, and is verified correct by examining the AsciiString class definition.
• No files require special attention.

Important Files Changed

Filename	Overview
Generals/Code/GameEngine/Source/GameLogic/Object/Object.cpp	Single-character fix: .c_str() → .str() on AsciiString return from toHexString() in the non-RETAIL_COMPATIBLE_CRC debug CRC logging path. Correct and safe.
GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Object.cpp	Identical single-character fix: .c_str() → .str() on AsciiString return from toHexString() in the non-RETAIL_COMPATIBLE_CRC debug CRC logging path. Correct and safe.

Flowchart

flowchart TD
    A["Object::crc() called"] --> B{"RETAIL_COMPATIBLE_CRC?"}
    B -- Yes --> C["xferUser with sizeof(Int64)"]
    B -- No --> D["xferUser with sizeof(m_objectUpgradesCompleted)"]
    C --> E{"DEBUG_CRC && doLogging?"}
    D --> E
    E -- No --> G["Continue CRC processing"]
    E -- Yes --> F{"RETAIL_COMPATIBLE_CRC?"}
    F -- Yes --> H["tmp.format with %I64X"]
    F -- No --> I["tmp.format with toHexString().str()
(was .c_str() — compile error)"]
    H --> G
    I --> G

Loading

_{Last reviewed commit: 49c4fc6}

[Skyaero42]

Should we maybe add a build in the pipeline that also compiles at least one version without RETAIL_COMPATIBLE_CRC, now that so much code is encapsulated with this guard?

[xezon]

Yes we could do that.

[tintinhamans]

Should we maybe add a build in the pipeline that also compiles at least one version without RETAIL_COMPATIBLE_CRC, now that so much code is encapsulated with this guard?

Please create a task for this and assign to me, I will look at this ASAP. Do we want this for all variations or only vc6/win32 release.