bugfix(worldbuilder): Fix uncaught carriage return in CommandButton name when parsing from INI

[ViTeXFTW]

• Fixes Worldbuilder: adding/removing command buttons have an invisible character, causing the script to appear with an error #414

Description
This PR fixes an issue in WorldBuilder where CommandButton validation incorrectly reports "Command button does not exist" errors when using the Add a CommandButton to an object type. The issue occurs when CommandButton names are loaded from INI files - the names contain trailing carriage return characters from Windows line endings, causing string comparisons to fail even though the buttons exist and display correctly in the UI.

This means for mappers they get a visual indication that their script has an error when the CommandButton name is correct and a false positive when the CommandButton name still has the trailing carriage return.

Root Cause
The strtok delimiter array in loadCommandButtons() only included " ,\t\n"

Fix in EditParameter.cpp. In loadCommandButtons(): added \r to the delimiter.

Old:

New:

TODO

• Replicate in Generals

[greptile-apps]

Greptile Summary

Adds \r (carriage return) to the strtok delimiter string in loadCommandButtons() for both the Generals and GeneralsMD versions of EditParameter.cpp. This fixes false "Command button does not exist" validation errors in WorldBuilder caused by trailing \r characters from Windows-style line endings (\r\n) in INI files not being stripped during tokenization.

• Added \r to the seps delimiter array in Generals/Code/Tools/WorldBuilder/src/EditParameter.cpp
• Added \r to the seps delimiter array in GeneralsMD/Code/Tools/WorldBuilder/src/EditParameter.cpp
• The fix is consistent with how ParticleSys.cpp already handles the same issue with its own seps array
• loadCommandButtons() is the only load function in EditParameter.cpp that parses INI files directly with strtok; other load functions use in-memory stores and are not affected

Confidence Score: 5/5

• This PR is safe to merge — it is a minimal, well-understood one-character bugfix applied consistently to both game variants.
• The change adds a single character (\r) to a delimiter string in two parallel files. The fix is correct: strtok needs \r as a delimiter to handle Windows CRLF line endings. The change is consistent with existing patterns in the codebase (e.g., ParticleSys.cpp). No other code paths are affected. Risk of regression is effectively zero.
• No files require special attention.

Important Files Changed

Filename	Overview
GeneralsMD/Code/Tools/WorldBuilder/src/EditParameter.cpp	Single-character addition of \r to strtok delimiter string in loadCommandButtons() — correct and safe fix for carriage return stripping.
Generals/Code/Tools/WorldBuilder/src/EditParameter.cpp	Identical single-character addition of \r to strtok delimiter string in loadCommandButtons() — mirrors the GeneralsMD fix.

Flowchart

flowchart TD
    A["loadCommandButtons() called"] --> B["Open CommandButton.ini"]
    B --> C["Read line into buf via nextLine()"]
    C --> D["Tokenize with strtok(buf, seps)"]
    D --> E{"Token == 'CommandButton'?"}
    E -->|Yes| F["Get next token (button name)"]
    F --> G{"Before fix:\nseps = ' ,\\t\\n'"}
    F --> H{"After fix:\nseps = ' ,\\t\\n\\r'"}
    G --> I["Token retains trailing \\r\ne.g. 'ButtonName\\r'"]
    H --> J["Token is clean\ne.g. 'ButtonName'"]
    I --> K["strcmp fails → false 'does not exist' error"]
    J --> L["strcmp succeeds → correct validation"]

Loading

_{Last reviewed commit: 9bc2c9a}

[xezon]

The title needs to say what this fixes.

[xezon]

Needs to be replicated to Generals.