Closed
Conversation
Starting poking at installing via ProcessStartInfo
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to manage Windows OCR language settings by updating UI bindings, introducing an Admin window for language installation, and enhancing utility methods with modern C# collection expressions. Key changes include:
- Refactoring XAML bindings for improved readability.
- Adding a new Admin window (and its associated XAML and code-behind) to install and load Windows OCR languages.
- Integrating modern C# array/collection literal syntax in language utility methods and language settings.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Text-Grab/Views/GrabFrame.xaml | Reformatted binding expressions to span multiple lines for clarity. |
| Text-Grab/Views/AdminWindow.xaml.cs | New admin window logic for installing Windows OCR language packs using Dism API. |
| Text-Grab/Views/AdminWindow.xaml | New UI view for the Admin window enabling language management. |
| Text-Grab/Utilities/WindowsLanguageUtilities.cs | Introduced methods for generating PowerShell and DISM commands using the new array literal syntax. |
| Text-Grab/Text-Grab.csproj | Added Microsoft.Dism package dependency. |
| Text-Grab/Pages/LanguageSettings.xaml.cs | Updated binding initialization using modern collection expression and added a new admin event. |
| Text-Grab/Pages/LanguageSettings.xaml | Added a new button to launch the Windows OCR language management functionality. |
| Text-Grab/App.xaml.cs | Added a check for running the Admin window instance and launching it based on arguments. |
Comments suppressed due to low confidence (2)
Text-Grab/Views/AdminWindow.xaml.cs:40
- [nitpick] The method name 'InstalWindowsLangButton_Click' appears to be misspelled. Consider renaming it to 'InstallWindowsLangButton_Click' for clarity and consistency.
private async void InstalWindowsLangButton_Click(object sender, RoutedEventArgs e)
Text-Grab/Pages/LanguageSettings.xaml.cs:156
- [nitpick] The method name 'InstalWindowsLangButton_Click' may be unintentionally misspelled. For clarity, consider updating it to 'InstallWindowsLangButton_Click'.
private void InstalWindowsLangButton_Click(object sender, RoutedEventArgs e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.