Fix bugs and typo errors in closest_pair_of_points.py #14355
Open
Roy027 wants to merge 17 commits intoTheAlgorithms:masterfrom
Open
Fix bugs and typo errors in closest_pair_of_points.py #14355Roy027 wants to merge 17 commits intoTheAlgorithms:masterfrom
Roy027 wants to merge 17 commits intoTheAlgorithms:masterfrom
Conversation
There are typo errors in closest_pair_points function and errors in dis_between_closest_in_strip function.
There are typo errors in closest_pair_points function and errors in dis_between_closest_in_strip function.
There are typo errors in closest_pair_points function and errors in dis_between_closest_in_strip function.
There are typo errors in closest_pair_points function and errors in dis_between_closest_in_strip function.
Fix bugs and typo errors in closest pair of points
Summary This pull request addresses critical logic errors and typos in the closest_pair_of_points.py algorithm. These fixes ensure the algorithm produces mathematically correct results and passes all automated tests. Key Fixes: Loop Logic Correction: In dis_between_closest_in_strip , the search loop was modified to correctly check all necessary pairs within the strip optimization. Recursion Parameter Fix: Corrected a typo in closest_pair_of_points_sqr where the X-sorted list was not being correctly partitioned for recursive calls. Doctest Alignment: Updated the doctest in dis_between_closest_in_strip from 85 to 5 to reflect the correct mathematical result after the logic fix. The previous expected value of 85 was a result of the bugged implementation.
for more information, see https://pre-commit.ci
algorithms-keeper
bot
added
enhancement
for more information, see https://pre-commit.ci
Author
|
sorry accidentally modified DIRECTORY.md but i have removed changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Summary
This PR fixes several logic errors in
divide_and_conquer/closest_pair_of_points.py.The strip search loop previously skipped valid comparisons due to incorrect
loop bounds. The recursive call also passed an incorrect sorted list,
breaking the divide-and-conquer step of the algorithm.
The doctest for
dis_between_closest_in_strip()previously expected85,which only occurred because the buggy implementation skipped valid point
comparisons. After fixing the logic, the correct result is
5.Checklist: