Add: CombinationSum algorithm (Fixes #6804)#6869
Closed
Tejasrahane wants to merge 5 commits intoTheAlgorithms:masterfrom
Closed
Add: CombinationSum algorithm (Fixes #6804)#6869Tejasrahane wants to merge 5 commits intoTheAlgorithms:masterfrom
Tejasrahane wants to merge 5 commits intoTheAlgorithms:masterfrom
Conversation
Implements the Combination Sum algorithm using recursion and backtracking. This class finds all unique combinations of distinct integers that sum to a target value, where numbers can be used multiple times. - Added comprehensive JavaDoc documentation - Included Wikipedia and LeetCode references - Follows project naming conventions - Uses proper recursion and backtracking techniques Fixes TheAlgorithms#6804
Tejasrahane
requested review from
DenizAltunkapan,
alxkm and
yanglbme
as code owners
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6869 +/- ##
============================================
+ Coverage 77.96% 78.01% +0.04%
- Complexity 6431 6450 +19
============================================
Files 736 738 +2
Lines 21476 21534 +58
Branches 4204 4211 +7
============================================
+ Hits 16744 16799 +55
- Misses 4060 4062 +2
- Partials 672 673 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@Tejasrahane Please add a corresponding test class so i can start the review |
Author
|
Thank you for the review @DenizAltunkapan! I will add a corresponding test class for the CombinationSum algorithm to ensure proper test coverage. Could you please confirm if there are any specific test cases or edge cases you would like me to include in the test class? I want to make sure the tests meet the project's standards for the review process. I'll update the PR with the test class shortly. |
This test class covers various scenarios for the CombinationSum algorithm, including edge cases and multiple combinations.
Removed all instances of 'new CombinationSum()' in testBasicCase, testMultipleCombinations, and testNoSolution methods. Updated all calls to use the static method CombinationSum.combinationSum() directly instead of creating an instance, as the CombinationSum class has a private constructor and is designed to be used statically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the Combination Sum algorithm using recursion and backtracking. This class finds all unique combinations of distinct integers that sum to a target value, where numbers can be used multiple times.
Fixes #6804
clang-format -i --style=file path/to/your/file.java