Fix ConvexHull to return points in counter-clockwise order#6810
Merged
DenizAltunkapan merged 3 commits intoTheAlgorithms:masterfrom Oct 19, 2025
Merged
Conversation
- Add sortCounterClockwise method to ensure CCW ordering - Start from bottom-most, left-most point for deterministic results - Fix issue where unordered HashSet broke downstream algorithms - Add comprehensive tests with CCW order verification
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6810 +/- ##
============================================
+ Coverage 77.93% 77.95% +0.02%
- Complexity 6420 6430 +10
============================================
Files 736 736
Lines 21444 21476 +32
Branches 4198 4204 +6
============================================
+ Hits 16712 16742 +30
Misses 4061 4061
- Partials 671 673 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DenizAltunkapan
approved these changes
Oct 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the
convexHullRecursivemethod to return points in counter-clockwise (CCW) order, resolving issues with downstream geometric algorithms.Problem
The original implementation used
HashSetto collect hull points, which doesn't preserve order. This caused:Solution
sortCounterClockwise()method to sort points in CCW orderdistanceSquared()helper to handle collinear points correctlyisCounterClockwise()verificationChanges
Modified Files
ConvexHull.java: Added CCW sorting logicConvexHullTest.java: Added CCW order verification testsKey Methods Added
sortCounterClockwise(): Sorts hull points in CCW order from pivotdistanceSquared(): Computes squared distance for collinear point handlingTesting
All existing tests pass, plus new tests verify:
Example
Related Issues
Fixes #6605
Checklist