fix: Nearest Greater and Smaller Element Algorithm (Fixes #6656)#6693
Closed
sgindeed wants to merge 7 commits intoTheAlgorithms:masterfrom
Closed
fix: Nearest Greater and Smaller Element Algorithm (Fixes #6656)#6693sgindeed wants to merge 7 commits intoTheAlgorithms:masterfrom
sgindeed wants to merge 7 commits intoTheAlgorithms:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6693 +/- ##
============================================
+ Coverage 75.80% 75.87% +0.06%
- Complexity 5804 5828 +24
============================================
Files 705 706 +1
Lines 19846 19890 +44
Branches 3851 3863 +12
============================================
+ Hits 15045 15091 +46
+ Misses 4218 4217 -1
+ Partials 583 582 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Thank you for your contribution! @sgindeed Your proposed implementation overlaps with these existing ones, so we cannot accept another separate class of the same type. If you’d like, you can instead improve or refactor the existing classes — for example, by adding clearer documentation, optimizing the logic, or unifying the pattern across “greater” and “smaller” variants. Thank you again for your effort and understanding! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clang-format -i --style=file path/to/your/file.java