refactor: Enhance docs, add tests in PrintMatrixInSpiralOrder#6636
Merged
DenizAltunkapan merged 9 commits intoTheAlgorithms:masterfrom Oct 22, 2025
Merged
refactor: Enhance docs, add tests in PrintMatrixInSpiralOrder#6636DenizAltunkapan merged 9 commits intoTheAlgorithms:masterfrom
PrintMatrixInSpiralOrder#6636DenizAltunkapan merged 9 commits intoTheAlgorithms:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6636 +/- ##
============================================
- Coverage 78.00% 77.98% -0.03%
+ Complexity 6444 6436 -8
============================================
Files 737 736 -1
Lines 21519 21499 -20
Branches 4208 4201 -7
============================================
- Hits 16785 16765 -20
- Misses 4062 4063 +1
+ Partials 672 671 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DenizAltunkapan
requested changes
Oct 9, 2025
Member
DenizAltunkapan
left a comment
There was a problem hiding this comment.
@Hardvan
I found that there are multiple PrintAMatrixInSpiralOrder classes:
com.thealgorithms.matrix.PrintAMatrixInSpiralOrdercom.thealgorithms.others.PrintAMatrixInSpiralOrder
Please remove the duplicate class in the others package and ensure that only one class remains in the matrix package.
Also, move your updated class (with improved documentation) and the corresponding test file into the matrix package so at the end there exists only one class in the matrix folder
Contributor
Author
|
@DenizAltunkapan Done |
Member
|
Thanks @Hardvan. Please merge from master to merge this pr. |
Member
|
@Hardvan Please resolve the conficts |
DenizAltunkapan
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clang-format -i --style=file path/to/your/file.java