Fix/convex hull order#6623
Closed
Kavindya-Kariyawasam wants to merge 7 commits intoTheAlgorithms:masterfrom
Closed
Fix/convex hull order#6623Kavindya-Kariyawasam wants to merge 7 commits intoTheAlgorithms:masterfrom
Kavindya-Kariyawasam wants to merge 7 commits intoTheAlgorithms:masterfrom
Conversation
Implemented Graham's scan algorithm to ensure convex hull points are returned in CCW order. This fixes issues with downstream algorithms like Rotating Calipers that require properly ordered hull vertices.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6623 +/- ##
============================================
- Coverage 75.74% 75.63% -0.11%
Complexity 5765 5765
============================================
Files 701 701
Lines 19757 19771 +14
Branches 3831 3835 +4
============================================
- Hits 14964 14954 -10
- Misses 4214 4235 +21
- Partials 579 582 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…r SpotBugs compliance
…sConstructor Checkstyle rule
Member
|
@Kavindya-Kariyawasam Please fix the failing workflows so I can start the review. |
|
This pull request has been automatically closed because its workflows or checks failed and it has been inactive for more than 14 days. Please fix the workflows and reopen if you'd like to continue. Merging from main/master alone does not count as activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented Graham's scan algorithm to ensure convex hull points are returned in CCW order. This fixes issues with downstream algorithms like Rotating Calipers that require properly ordered hull vertices.
clang-format -i --style=file path/to/your/file.java