ConvexHull Hashset Loss of order fix#6609
Closed
yadhu-vipin wants to merge 3 commits intoTheAlgorithms:masterfrom
yadhu-vipin:master
Closed
ConvexHull Hashset Loss of order fix#6609yadhu-vipin wants to merge 3 commits intoTheAlgorithms:masterfrom yadhu-vipin:master
yadhu-vipin wants to merge 3 commits intoTheAlgorithms:masterfrom
yadhu-vipin:master
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6609 +/- ##
============================================
- Coverage 75.68% 75.65% -0.03%
+ Complexity 5754 5738 -16
============================================
Files 699 699
Lines 19725 19697 -28
Branches 3826 3817 -9
============================================
- Hits 14929 14902 -27
+ Misses 4216 4215 -1
Partials 580 580 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in the
ConvexHullclass where the recursive method returned hull points in an unordered fashion due to the use of aHashSet. This caused algorithms that rely on vertex order, such as Rotating Calipers, to produce incorrect results (e.g., incorrect minimum bounding rectangle areas).The fix preserves the counter-clockwise (CCW) order of the hull points while maintaining all points that lie on the convex polygon. This ensures compatibility with downstream geometric algorithms.
Changes:
HashSetwithLinkedHashSetorList+ sorting to preserve order.Impact: