fix: heap-buffer-overflow in run_length_encoding.c#1329
Open
vil02 wants to merge 1 commit intoTheAlgorithms:masterfrom
Open
fix: heap-buffer-overflow in run_length_encoding.c#1329vil02 wants to merge 1 commit intoTheAlgorithms:masterfrom
heap-buffer-overflow in run_length_encoding.c#1329vil02 wants to merge 1 commit intoTheAlgorithms:masterfrom
Conversation
Contributor
|
This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Member
Author
|
@Panquesito7, @tjgurwara99, @alexpantyukhin could some of you please add a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Running
run_length_encoding.cleads toheap-buffer-overflow. Theencodedis one too short. Moreover, there is an error in this test case:C/misc/run_length_encoding.c
Line 77 in e5dad3f
Note that the last character of the output of the function
run_length_encodehas to be the same as the last character of the input.This PR fixes the mentioned issues and adds new test cases.
References
Checklist
Notes:
This PR fixes the
heap-buffer-overflowinrun_length_encoding.c.