feat: add boyer-moore majority vote algorithm#3167
Open
ElmeSelhyy wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey everyone
I was browsing the repository and noticed that while there's already a Boyer-Moore algorithm for string matching under strings/, the classic Boyer-Moore Majority Vote algorithm was missing from the search/ directory. I figured it would make a great addition to the collection, so I put this together to fill the gap!
What I've done:
New File: Added search/boyer_moore_majority_vote.cpp to find the majority element (the one that shows up more than n/2 times) in an array.
Efficiency: Kept it optimal with O(n) time complexity and O(1) space.
Structure: Wrapped the logic neatly inside a dedicated search::boyer_moore_majority namespace to match the repository's layout.
Testing: Included self-contained assert() test cases inside main() that cover standard arrays, identical elements, and tricky edge cases. I also made sure not to use any interactive inputs (std::cin) so the automated testing bots run perfectly without hanging.