Use quote for vendored yaml-cpp dependency. #8731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

maliberty merged 1 commit into The-OpenROAD-Project:master from hzeller:feature-20251024-yaml2

Oct 25, 2025

Contributor

hzeller commented Oct 24, 2025

This will trigger a new misc-include-cleaner warning as the yaml-header does not have IWYU annotations. So we should ignore such clang-tidy warning for now.

I am upstreaming the necessary IWYU pragmas in
jbeder/yaml-cpp#1378


          Use quote for vendored yaml-cpp dependency.

0ce987e

This will trigger a new `misc-include-cleaner` warning
as the yaml-header does not have IWYU annotations. So
we should ignore such clang-tidy warning for now.

I am upstreaming the necessary IWYU pragmas in
jbeder/yaml-cpp#1378

Signed-off-by: Henner Zeller <h.zeller@acm.org>

hzeller force-pushed the feature-20251024-yaml2 branch from 78ff431 to 0ce987e Compare

October 24, 2025 14:37

github-actions bot reviewed

View reviewed changes

Contributor

github-actions bot left a comment

clang-tidy made some suggestions

src/odb/src/3dblox/baseParser.cpp

    
              #include "objects.h"

              #include "utl/Logger.h"

              #include "yaml-cpp/yaml.h"

              namespace odb {

Contributor

github-actions bot Oct 24, 2025

warning: included header yaml.h is not used directly [misc-include-cleaner]

Suggested change

      
            namespace odb {
          
            namespace odb {

src/odb/src/3dblox/baseParser.h

    
              #include <vector>

              #include "yaml-cpp/yaml.h"

Contributor

github-actions bot Oct 24, 2025

warning: included header yaml.h is not used directly [misc-include-cleaner]

Suggested change

src/odb/src/3dblox/dbvParser.cpp

    
              #include "odb/db.h"

              #include "utl/Logger.h"

              #include "yaml-cpp/yaml.h"

Contributor

github-actions bot Oct 24, 2025

warning: included header yaml.h is not used directly [misc-include-cleaner]

Suggested change

src/odb/src/3dblox/dbvParser.h

    
              #include "baseParser.h"

              #include "objects.h"

              #include "yaml-cpp/yaml.h"

Contributor

github-actions bot Oct 24, 2025

warning: included header yaml.h is not used directly [misc-include-cleaner]

Suggested change

src/odb/src/3dblox/dbxParser.cpp

    
              #include "odb/db.h"

              #include "utl/Logger.h"

              #include "yaml-cpp/yaml.h"

Contributor

github-actions bot Oct 24, 2025

warning: included header yaml.h is not used directly [misc-include-cleaner]

Suggested change

src/odb/src/3dblox/dbxParser.h

    
              #include "baseParser.h"

              #include "objects.h"

              #include "yaml-cpp/yaml.h"

Contributor

github-actions bot Oct 24, 2025

warning: included header yaml.h is not used directly [misc-include-cleaner]

Suggested change

Contributor Author

hzeller commented Oct 24, 2025

all the clang-tidy complaints shall be ignored for this one.

Contributor Author

hzeller commented Oct 24, 2025

... and the CI failure is unrelated

maliberty approved these changes

View reviewed changes

maliberty merged commit 91a1036 into The-OpenROAD-Project:master

12 of 13 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet