Core/Player: Fix MAX_TITLE_INDEX calculation for title mask#461
Open
gonzo1247 wants to merge 1 commit intoThe-Cataclysm-Preservation-Project:masterfrom
Open
Core/Player: Fix MAX_TITLE_INDEX calculation for title mask#461gonzo1247 wants to merge 1 commit intoThe-Cataclysm-Preservation-Project:masterfrom
gonzo1247 wants to merge 1 commit intoThe-Cataclysm-Preservation-Project:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed:
Players were unable to select titles with a bit index greater than 31.
This was caused by an incorrect MAX_TITLE_INDEX calculation introduced when
the original macros were replaced with constexpr values. The calculation used
sizeof(uint64) instead of 64 bits, limiting the valid range to 32 instead of 256.
The title mask size calculation has been corrected.
Issues addressed: Fixes #
Players could not change titles if the title ID was greater than 31.
Regression introduced in commit:
c4f1f8d
Tests performed: (Does it build, tested in-game, etc)