Target dest nearby entry 2#418
Open
gonzo1247 wants to merge 3 commits intoThe-Cataclysm-Preservation-Project:masterfrom
Open
Target dest nearby entry 2#418gonzo1247 wants to merge 3 commits intoThe-Cataclysm-Preservation-Project:masterfrom
gonzo1247 wants to merge 3 commits intoThe-Cataclysm-Preservation-Project:masterfrom
Conversation
… more as one possible summon position that is fix and not a random point. Summons without TARGET_DEST_NEARBY_ENTRY_2 and more as 1 summon use now the random point generated position to summon the creatures.
…n-Project/TrinityCore into TARGET_DEST_NEARBY_ENTRY_2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed:
TARGET_DEST_NEARBY_ENTRY_2 uses multiple locations for a given number of summons. The positions are more than creatures to be summoned.
So far, the code block for the random positions was called, but the "dest" variable was not used afterwards, meaning that the random position was unused.
Issues addressed: Fixes #
Tests performed: (Does it build, tested in-game, etc)
It's testet Ingame with the Spell 89616 (Summon Hyenas Right) and it's works.
Known issues and TODO list: