Fix ValueError in _guess_lexer for single-line source files#4009
Closed
bysiber wants to merge 1 commit intoTextualize:masterfrom
Closed
Fix ValueError in _guess_lexer for single-line source files#4009bysiber wants to merge 1 commit intoTextualize:masterfrom
bysiber wants to merge 1 commit intoTextualize:masterfrom
Conversation
Member
|
Your PR has been closed due to a AI policy violation. Please read the following before submitting further PRs. https://github.com/Textualize/textual/blob/main/AI_POLICY.md @bysiber One more AI PR and you will be permanently banned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_guess_lexerusesstr.index()to find the first newline in source code, butindex()raisesValueErrorwhen the substring isn't found. The subsequent checkif new_line_index != -1only makes sense withstr.find(), which returns-1on miss.When a traceback includes a frame from a single-line source file (no trailing newline),
_guess_lexercrashes with an unhandledValueErrorinstead of rendering the traceback.Changed
code.index("\n")→code.find("\n")so the existing-1guard works as intended.