Fix Panel crash when box=None#3976
Open
karthiksai109 wants to merge 1 commit intoTextualize:masterfrom
Open
Conversation
Contributor
No it doesn't? The linked issue is already closed because the docstring was corrected to reflect this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Panel.init accepts box as Optional[Box] but passing None causes an AttributeError in rich_console because it calls self.box.substitute() without checking for None first.
This handles box=None throughout the rendering and measurement paths, similar to how Table already supports box=None. When box is None the panel content renders without any border.
Fixes #3609