docs(contributing): remove another reference to poetry shell#3971
docs(contributing): remove another reference to poetry shell#3971TomJGooding wants to merge 1 commit intoTextualize:masterfrom
Conversation
The shell command was removed in Poetry 2.0 back in January 2025. When `CONTRIBUTING.md` was updated recently to reflect this change, it looks like another reference to `poetry shell` was missed.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3971 +/- ##
=======================================
Coverage 97.87% 97.87%
=======================================
Files 96 96
Lines 8363 8366 +3
=======================================
+ Hits 8185 8188 +3
Misses 178 178
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| Enter the directory containing your copy of Rich (`cd rich`). | ||
|
|
||
| Next create and activate a [virtual environment](https://packaging.python.org/en/latest/guides/installing-using-pip-and-virtual-environments/#create-and-use-virtual-environments) for Rich. |
There was a problem hiding this comment.
I confess I'm not really that familiar with Poetry, but can I just check if this is the correct guidance to create and activate a virtual environment?
If I've understood the Poetry docs correctly, isn't a virtual environment created by default?
The new env activate command is also recommended to activate the virtual environment (though it should be noted that this is not a direct replacement for the shell command).
There was a problem hiding this comment.
I understand that "Poetry will detect and respect an existing virtual environment", but I just wanted to confirm the recommended workflow.
2 participants
The shell command was removed in Poetry 2.0 back in January 2025.
When
CONTRIBUTING.mdwas updated recently to reflect this change, it looks like another reference topoetry shellwas missed.Closes #3634
Closes #3817
Type of changes
AI?
AI generated PRs may be accepted, but only if @willmcgugan has responded on an issue or discussion.
Checklist