Add support for setting --hyperlinks via the RICH_HYPERLINKS environment variable#61
Add support for setting --hyperlinks via the RICH_HYPERLINKS environment variable#61andelink wants to merge 2 commits intoTextualize:mainfrom
--hyperlinks via the RICH_HYPERLINKS environment variable#61Conversation
|
@willmcgugan here's the PR |
harkabeeparolus
left a comment
There was a problem hiding this comment.
The code changes and documentation look good to me!
I wouldn't personally submit a PR that bumps the version number, but other than that I see no problems. 😊
|
Thanks @harkabeeparolus! Reason I bumped the version is to hopefully get a new release of the library, so I can install and begin using these changes 🙂 (Also, I don't have permissions to merge the changes since I don't have write access to the repo, so merging is in your hands.) |
|
@harkabeeparolus would a patch version update be more welcome? - version = "1.8.0"
+ version = "1.8.1" |
I wouldn't know, I'm just a random pythonista on GitHub — I don't have any commit access either. 😊 I just don't think I'd personally make a PR with an included version bump. Unless it was specifically about assisting the maintainers with a new release. But maybe that's just me. 🤔 (I do believe minor version would be appropriate from a Semantic Versioning perspective, since patch versions are supposed to be bugfixes without new features.) |
Small commit to allow setting
--hyperlinksvia theRICH_HYPERLINKSenvironment variable, so users can export this in their shell rc file and always have hyperlinks enabled.Corresponding issue:
--hyperlinksvia theRICH_HYPERLINKSenvironment variable #62