Skip to content

Conversation

@zbalkan
Copy link

@zbalkan zbalkan commented Jan 29, 2026

…t we can use latest version. The minimum version 5.0 had vulnerabilities.

…t we can use latest version. The minimum version 5.0 had vulnerabilities.
Copilot AI review requested due to automatic review settings January 29, 2026 08:23
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins System.Formats.Asn1 as a top-level dependency in TechnitiumLibrary.Security.Cryptography to allow updating beyond a vulnerable minimum transitive version.

Changes:

  • Add an explicit PackageReference to System.Formats.Asn1 (version 10.0.2) in the cryptography project.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

</PropertyGroup>

<ItemGroup>
<PackageReference Include="System.Formats.Asn1" Version="10.0.2" />
Copy link

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds a new direct NuGet dependency to the produced package. If the intent is only to override a transitive version for this project (and not force downstream consumers to take a dependency on System.Formats.Asn1), consider marking it as PrivateAssets="all" (or using an equivalent version-pinning approach) to avoid changing the dependency surface. Also double-check that the chosen 10.0.2 version is compatible with this project’s net9.0 target to prevent restore/runtime binding issues.

Copilot uses AI. Check for mistakes.
@zbalkan
Copy link
Author

zbalkan commented Jan 29, 2026

It's better to wait dotnet 10 update or we can roll back to a dotnet 9 compatible but not vulnerable version.

@ShreyasZare
Copy link
Member

It's better to wait dotnet 10 update or we can roll back to a dotnet 9 compatible but not vulnerable version.

.NET 10 is being planned in the next update or at most the one after it.

@zbalkan
Copy link
Author

zbalkan commented Jan 29, 2026

But the vulnerability is there. Since this is not used in DNS Server, the impact is related to your work, I believe. So, I can do the minor change the way you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants