Added tests for TechnitiumLibrary.Net, kept the failing tests on purpose #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zafer Balkan <zafer@zaferbalkan.com>
There was a problem hiding this comment.
Pull request overview
This pull request adds comprehensive unit test coverage for TechnitiumLibrary.Net components. The PR includes tests for networking utilities, proxy servers, DNS record types, and HTTP functionality. According to the description, some tests are intentionally left failing to facilitate discussion about behaviors that may violate RFC specifications.
Changes:
- Added two test projects (TechnitiumLibrary.UnitTests and TechnitiumLibrary.Tests) with extensive test coverage
- Configured GitHub Actions workflow for automated testing
- Updated README with testing status badge
Reviewed changes
Copilot reviewed 101 out of 101 changed files in this pull request and generated 26 comments.
Show a summary per file
| File | Description |
|---|---|
| TechnitiumLibrary.sln | Added TechnitiumLibrary.UnitTests project reference |
| TechnitiumLibrary.UnitTests/TechnitiumLibrary.UnitTests.csproj | Test project targeting .NET 9.0 with MSTest SDK |
| Multiple test files | Comprehensive tests for Socket extensions, Proxy components, DNS records, HTTP handling |
| .github/workflows/unit-testing.yml | CI workflow for running tests on Windows with MSBuild |
| README.md | Added testing status badge |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TechnitiumLibrary.Tests/TechnitiumLibrary.Net/Http/Client/HttpClientNetworkHandlerTests.cs
Show resolved
Hide resolved
TechnitiumLibrary.Tests/TechnitiumLibrary.Net/ProxyProtocol/ProxyProtocolStreamTests.cs
Show resolved
Hide resolved
TechnitiumLibrary.Tests/TechnitiumLibrary.Net/ProxyProtocol/ProxyProtocolStreamTests.cs
Show resolved
Hide resolved
TechnitiumLibrary.UnitTests/TechnitiumLibrary.Net/IPAddressExtensionsTests.cs
Outdated
Show resolved
Hide resolved
TechnitiumLibrary.UnitTests/TechnitiumLibrary.Net/ProxyProtocol/ProxyProtocolStreamTests.cs
Outdated
Show resolved
Hide resolved
TechnitiumLibrary.UnitTests/TechnitiumLibrary.Net/ProxyProtocol/ProxyProtocolStreamTests.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some behaviors need discussion being against RFCs.