Skip to content
This repository was archived by the owner on Jan 30, 2018. It is now read-only.

Update Parents_content.php #5

Open
ZodiacChaser wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Parents_content.php #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions content/Parents_content.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,20 @@
</p>
</div>
</div>
<div class="post">
<h1 class="title"><a>New Year Student Signups</a></h1>
</p>
</div>
</div>
<div class="post">
<h1 class="title"><a>Want to join for our team?</a></h1>
<p class="byline"><small>Posted on August 24th, 2015</small></p>
<div class="entry">
<p>
Please fill out the below papers and bring them with you to the next open shop night: </br>
Copy link

@evilsoft evilsoft Apr 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is a 👃 to use <br> also the the slash is not needed for html5 (and it is on the wrong side anyway)
it would be better to wrap the text node in the <p> block, and just throw your <ul> block below it.
You NEVER should leave text nodes as peers to html elements. The render cycle has a super bad time when flowing the document.

I would suggest a structure like:

<div class="entry">
  <p>
    Please fill out the below papers and bring them with you to the next open shop night:
  </p>
  <ul class="papers">
    <li class="papers__item"><a target="_blank" href="some-url">Some Text</a></li>
    <li class="papers__item"><a target="_blank" href="some-url">Some Text</a></li>
    <li class="papers__item"><a target="_blank" href="some-url">Some Text</a></li>
  </ul>
</div>

Structuring your html this way is good for the soul AND the flow cycle.

Copy link

@evilsoft evilsoft Apr 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this is an old PR...man oh man...

<ul></br><a style=\"target-new: tab\" target=\"new\" href="toolcert.docx">FRC Tool Certification (docx)</a></ul></br>
Copy link

@evilsoft evilsoft Apr 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the <ul> here?
<ul> should include <li> as their children and wrap your anchors...

<ul class="papers">
  <li class="papers__item"><a target="_blank" href="some-url">Some Text</a></li>
</ul>
.papers {
  padding: 0;
}

.papers__item: {
  padding: 16px 0; // should use rem, but that is a long discussion 
}

Some things to notice:

  • The use of target-new: xxx is a big 👃, target="_blank" allows for the user specified setting is more supported across browsers.

<ul></br><a style=\"target-new: tab\" target=\"new\" href="Team Handbook Updated 11-14">Team Handbook (doc)</a></ul></br>
<ul></br><a style=\"target-new: tab\" target=\"new\" href="Field Trip Permission Slip rev 0815">Field Trip Permission Slip (doc)</a></ul></br>
</p>
</div>
</div>