Skip to content

Refine ad script error suppression logic #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sentry wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Refine ad script error suppression logic #752

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cec15f0
Refine ad script error suppression logic
sentry[bot] Mar 12, 2026
e49daa9
ci: apply automated fixes
autofix-ci[bot] Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/router.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,18 @@ export function getRouter() {
errorMessage.includes('null is not an object') ||
errorMessage.includes('is not a function')

if (hasAdScriptFrame && hasExpectedErrorMessage) {
// Some ad script errors (e.g. Publift Fuse cross-origin iframe errors) have
// highly specific message patterns that identify them unambiguously, even when
// the stack trace has been obscured by Sentry's sentryWrapped helper and no
// ad-script frame is visible. Suppress these directly by message alone.
const isUnambiguousAdScriptError =
errorMessage.includes('window.top.document') ||
errorMessage.includes('isPlacementXdom')

if (
isUnambiguousAdScriptError ||
(hasAdScriptFrame && hasExpectedErrorMessage)
) {
// Suppress the error - log to console in debug mode
console.debug(
'Suppressed Publift Fuse/ad script error:',
Expand Down
Loading