Skip to content

Conversation

@Pascalmh
Copy link

@Pascalmh Pascalmh commented Jan 27, 2026

🎯 Changes

getIsSomePageRowsSelected no longer returns false when all rows of a page are selected

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Bug Fixes
    • Fixed getIsSomePageRowsSelected to correctly return true when all rows on a page are selected. Previously, this function would incorrectly return false when all selectable rows on the current page were selected, making it difficult to accurately track and determine row selection state. The fix ensures reliable and consistent selection detection.

✏️ Tip: You can customize this high-level summary in your review settings.

…age rows selected

Signed-off-by: Pascal Küsgen <pascalkuesgen@gmail.com>
@changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2026

🦋 Changeset detected

Latest commit: 6bc421c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@tanstack/table-core Patch
@tanstack/angular-table Patch
@tanstack/lit-table Patch
@tanstack/qwik-table Patch
@tanstack/react-table Patch
@tanstack/solid-table Patch
@tanstack/svelte-table Patch
@tanstack/vue-table Patch
@tanstack/react-table-devtools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link

coderabbitai bot commented Jan 27, 2026

📝 Walkthrough

Walkthrough

A patch version bump is introduced for @tanstack/table-core with a behavioral fix to the getIsSomePageRowsSelected function, which now correctly returns a boolean indicating whether any selectable rows on the current page are selected or partially selected, rather than returning a falsy result when all page rows are selected.

Changes

Cohort / File(s) Summary
Changeset Metadata
.changeset/late-radios-decide.md
Version bump entry documenting patch-level release for @tanstack/table-core with fix description
Row Selection Logic
packages/table-core/src/features/RowSelection.ts
Refactored getIsSomePageRowsSelected to return consistent boolean by filtering selectable rows and checking if any are selected or partially selected, replacing previous conditional logic

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A rabbit hops through table rows with glee,
Where selection logic flows now properly,
No false returns when all are picked and bright,
The page selection shines with truthful light! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the bug fix: getIsSomePageRowsSelected incorrectly returning false when all page rows are selected, which directly matches the core change in the changeset.
Description check ✅ Passed The pull request description includes all required template sections with proper completion: changes are described, all checklist items are checked, and release impact is properly indicated with a changeset generated.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Pascalmh
Copy link
Author

@KevinVandy said on Discord that this was an intentional change 3 years ago - it will be changed in v9

I'm closing this PR for that reason.

@Pascalmh Pascalmh closed this Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant