Skip to content

build: migrate from config to vite-config 0.4.3#6923

Open
birkskyum wants to merge 5 commits intomainfrom
vite-config
Open

build: migrate from config to vite-config 0.4.3#6923
birkskyum wants to merge 5 commits intomainfrom
vite-config

Conversation

@birkskyum
Copy link
Member

@birkskyum birkskyum commented Mar 14, 2026

Migrate from @tanstack/config to @tanstack/vite-config 0.4.3 (still on rollup)

vite-config patched, similar to:

Summary by CodeRabbit

  • New Features

    • Added two SSR lifecycle hooks to improve server render control and cleanup.
  • Chores

    • Switched to an updated vite configuration package and applied coordinated patch updates across many packages.
  • Bug Fixes

    • Restored build compatibility with the updated tooling configuration.

@changeset-bot
Copy link

changeset-bot bot commented Mar 14, 2026

🦋 Changeset detected

Latest commit: 12f606f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 40 packages
Name Type
@tanstack/start-static-server-functions Patch
@tanstack/react-router-ssr-query Patch
@tanstack/solid-router-ssr-query Patch
@tanstack/react-router-devtools Patch
@tanstack/router-ssr-query-core Patch
@tanstack/solid-router-devtools Patch
@tanstack/start-storage-context Patch
@tanstack/eslint-plugin-router Patch
@tanstack/nitro-v2-vite-plugin Patch
@tanstack/router-devtools-core Patch
@tanstack/vue-router-ssr-query Patch
@tanstack/virtual-file-routes Patch
@tanstack/vue-router-devtools Patch
@tanstack/react-start-client Patch
@tanstack/react-start-server Patch
@tanstack/router-vite-plugin Patch
@tanstack/solid-start-client Patch
@tanstack/solid-start-server Patch
@tanstack/start-client-core Patch
@tanstack/start-plugin-core Patch
@tanstack/start-server-core Patch
@tanstack/router-generator Patch
@tanstack/vue-start-client Patch
@tanstack/vue-start-server Patch
@tanstack/arktype-adapter Patch
@tanstack/router-devtools Patch
@tanstack/valibot-adapter Patch
@tanstack/start-fn-stubs Patch
@tanstack/router-plugin Patch
@tanstack/react-router Patch
@tanstack/router-utils Patch
@tanstack/solid-router Patch
@tanstack/react-start Patch
@tanstack/router-core Patch
@tanstack/solid-start Patch
@tanstack/zod-adapter Patch
@tanstack/router-cli Patch
@tanstack/vue-router Patch
@tanstack/vue-start Patch
@tanstack/history Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 14, 2026

📝 Walkthrough

Walkthrough

Replaces imports of @tanstack/config/vite with @tanstack/vite-config across the monorepo, updates root package.json and changeset to add @tanstack/vite-config@0.4.3, patches that package, switches a yargs import/initialization in the CLI, and adds two methods to the ServerSsr interface.

Changes

Cohort / File(s) Summary
Changeset & Root Manifest
\.changeset/tasty-falcons-say.md, package.json, patches/@tanstack__vite-config@0.4.3.patch
Adds patch changelog entries, removes @tanstack/config devDependency, adds @tanstack/vite-config@0.4.3 and a local patch file that changes TS compilerOptions.module to Node16.
Vite config import updates
packages/*/vite.config.ts, packages/*/vite.config.*.ts, packages/**/.../vite.config.ts
Replaced imports of tanstackViteConfig from @tanstack/config/vite@tanstack/vite-config across many package Vite config files; no other config logic changed.
Router core interface
packages/router-core/src/router.ts
Added two methods to ServerSsr interface: setRenderFinished(): void and cleanup(): void.
CLI import/usage
packages/router-cli/src/index.ts
Switched yargs from namespace to default import and initialized the CLI via yargs() (removed prior // @ts-expect-error``).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐇 I hopped through modules, swapped each line,
From config/vite to vite-config fine.
Two hooks now waiting where SSR sits,
The CLI learns to call — no more bits.
A tiny patch, a tidy sprint of mine.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The PR title clearly and concisely describes the main change: migrating from @tanstack/config to @tanstack/vite-config 0.4.3, which is the primary objective and focus of this changeset.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch vite-config
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Mar 14, 2026

View your CI Pipeline Execution ↗ for commit 12f606f

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 10m 28s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2m 16s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-15 02:42:26 UTC

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 14, 2026

Merging this PR will not alter performance

✅ 6 untouched benchmarks


Comparing vite-config (12f606f) with main (215cab4)

Open in CodSpeed

@birkskyum birkskyum marked this pull request as ready for review March 14, 2026 23:51
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.changeset/tasty-falcons-say.md:
- Line 44: Update the changeset note to fix the package name typo by replacing
the incorrect token "@tantack/vite-config" with the correct package name
"@tanstack/vite-config" in the changeset text so the dependency reference is
accurate.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 03e73af2-0fb4-4d3a-98ec-e69077bd48ef

📥 Commits

Reviewing files that changed from the base of the PR and between 215cab4 and 50068c4.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (47)
  • .changeset/tasty-falcons-say.md
  • package.json
  • packages/arktype-adapter/vite.config.ts
  • packages/eslint-plugin-router/vite.config.ts
  • packages/history/vite.config.ts
  • packages/nitro-v2-vite-plugin/vite.config.ts
  • packages/react-router-devtools/vite.config.ts
  • packages/react-router-ssr-query/vite.config.ts
  • packages/react-router/vite.config.ts
  • packages/react-start-client/vite.config.ts
  • packages/react-start-server/vite.config.ts
  • packages/react-start/vite.config.server-entry.ts
  • packages/react-start/vite.config.ts
  • packages/router-cli/src/index.ts
  • packages/router-cli/vite.config.ts
  • packages/router-core/src/router.ts
  • packages/router-core/vite.config.ts
  • packages/router-devtools-core/vite.config.ts
  • packages/router-devtools/vite.config.ts
  • packages/router-generator/vite.config.ts
  • packages/router-plugin/vite.config.ts
  • packages/router-ssr-query-core/vite.config.ts
  • packages/router-utils/vite.config.ts
  • packages/router-vite-plugin/vite.config.ts
  • packages/solid-router-devtools/vite.config.ts
  • packages/solid-router-ssr-query/vite.config.ts
  • packages/solid-router/vite.config.ts
  • packages/solid-start-client/vite.config.ts
  • packages/solid-start-server/vite.config.ts
  • packages/solid-start/vite.config.server-entry.ts
  • packages/solid-start/vite.config.ts
  • packages/start-client-core/vite.config.ts
  • packages/start-fn-stubs/vite.config.ts
  • packages/start-plugin-core/vite.config.ts
  • packages/start-server-core/vite.config.ts
  • packages/start-static-server-functions/vite.config.ts
  • packages/start-storage-context/vite.config.ts
  • packages/valibot-adapter/vite.config.ts
  • packages/virtual-file-routes/vite.config.ts
  • packages/vue-router-devtools/vite.config.ts
  • packages/vue-router-ssr-query/vite.config.ts
  • packages/vue-router/vite.config.ts
  • packages/vue-start-client/vite.config.ts
  • packages/vue-start-server/vite.config.ts
  • packages/vue-start/vite.config.server-entry.ts
  • packages/vue-start/vite.config.ts
  • packages/zod-adapter/vite.config.ts

@github-actions
Copy link
Contributor

Bundle Size Benchmarks

  • Commit: 215cab47e8b9
  • Measured at: 2026-03-15T02:32:53.977Z
  • Baseline source: history:215cab47e8b9
  • Dashboard: bundle-size history
Scenario Current (gzip) Delta vs baseline Raw Brotli Trend
react-router.minimal 87.13 KiB 0 B (0.00%) 274.22 KiB 75.76 KiB ▂▂▂▁███████
react-router.full 90.13 KiB 0 B (0.00%) 284.48 KiB 78.44 KiB ▂▂▂▁███████
solid-router.minimal 36.48 KiB 0 B (0.00%) 109.43 KiB 32.81 KiB ▁▁▁▁███████
solid-router.full 40.80 KiB 0 B (0.00%) 122.40 KiB 36.66 KiB ▁▁▁▁███████
vue-router.minimal 52.35 KiB 0 B (0.00%) 149.47 KiB 47.02 KiB ▁▁▁▁███████
vue-router.full 57.14 KiB 0 B (0.00%) 164.98 KiB 51.26 KiB ▁▁▁▁███████
react-start.minimal 99.71 KiB -4 B (-0.00%) 313.37 KiB 86.19 KiB ▂▂▂▁████████
react-start.full 103.02 KiB -1 B (-0.00%) 323.10 KiB 89.11 KiB ▂▂▂▁████████
solid-start.minimal 48.79 KiB 0 B (0.00%) 147.02 KiB 43.13 KiB ▁▁▁▁███████
solid-start.full 54.26 KiB 0 B (0.00%) 162.88 KiB 47.81 KiB ▁▁▁▁███████

Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 15, 2026

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@6923

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@6923

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@6923

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@6923

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@6923

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@6923

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@6923

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@6923

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@6923

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@6923

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@6923

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@6923

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@6923

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@6923

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@6923

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@6923

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@6923

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@6923

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@6923

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@6923

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@6923

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@6923

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@6923

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@6923

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@6923

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@6923

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@6923

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@6923

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@6923

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@6923

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@6923

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@6923

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@6923

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@6923

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@6923

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@6923

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@6923

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@6923

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@6923

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@6923

commit: 12f606f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment