fix: stabilize server function manifest build output by motopods · Pull Request #6763 · TanStack/router

motopods · 2026-02-25T11:48:31Z

generateManifestModule iterated serverFnsById via Object.entries without sorting, producing manifest map keys in insertion order — which varies across builds and causes non-deterministic build artifacts.

Changes

packages/start-plugin-core/src/start-compiler-plugin/plugin.ts: Sort manifest entries by key (alphabetically) before code generation.

const manifestEntries = Object.entries(serverFnsById)
  .sort(([a], [b]) => (a < b ? -1 : a > b ? 1 : 0)) // ensure stable key order
  .map(([id, fn]) => { ... })

Fix #6762

Summary by CodeRabbit

Chores
- Emitted manifest entries are now produced in a deterministic, sorted order by function ID, improving consistency of build outputs and downstream tooling that rely on manifest ordering.

…ManifestModule Co-authored-by: motopods <58200641+motopods@users.noreply.github.com>

coderabbitai · 2026-02-25T11:59:06Z

📝 Walkthrough

Walkthrough

The manifest generation now sorts manifestEntries by function ID in ascending order before mapping them to string entries; no other logic, error handling, or public API changes were made.

Changes

Cohort / File(s)	Summary
Manifest Sorting `packages/start-plugin-core/src/start-compiler-plugin/plugin.ts`	Sorts `manifestEntries` by function ID (ascending) prior to mapping to string entries to produce a deterministic manifest order.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Hop hop, the manifest's now aligned,
IDs in order, tidy and kind,
No scrambled lines, just neat design,
Builds hum smooth, hashes combine,
A little hop for code that's refined.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Title check	✅ Passed	The PR title clearly and concisely summarizes the main change: stabilizing server function manifest build output by sorting entries deterministically.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@packages/start-plugin-core/src/start-compiler-plugin/plugin.ts`:
- Line 117: Replace the locale-dependent comparator in the Array.prototype.sort
call that currently uses a.localeCompare(b); instead use a deterministic UTF-16
code-unit comparator, e.g. change the comparator in the .sort(([a], [b]) => ...)
expression to return (a < b ? -1 : a > b ? 1 : 0) so ordering is reproducible
across runtimes.

ℹ️ Review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c4027b6 and 5afbccf.

📒 Files selected for processing (1)

packages/start-plugin-core/src/start-compiler-plugin/plugin.ts

packages/start-plugin-core/src/start-compiler-plugin/plugin.ts

…ifest generation (#3) * Initial plan * Replace localeCompare with deterministic UTF-16 code unit comparison in generateManifestModule Co-authored-by: motopods <58200641+motopods@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: motopods <58200641+motopods@users.noreply.github.com>

schiller-manuel · 2026-02-26T16:11:15Z

please add a comment into the code why we are sorting here

nx-cloud · 2026-02-26T16:11:30Z

View your CI Pipeline Execution ↗ for commit fcfaec8

Command	Status	Duration	Result
`nx run tanstack-router-e2e-bundle-size:build --...`	✅ Succeeded	1m 28s	View ↗

☁️ Nx Cloud last updated this comment at 2026-02-26 16:26:54 UTC

pkg-pr-new · 2026-02-26T16:13:32Z

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@6763

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@6763

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@6763

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@6763

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@6763

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@6763

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@6763

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@6763

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@6763

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@6763

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@6763

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@6763

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@6763

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@6763

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@6763

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@6763

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@6763

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@6763

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@6763

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@6763

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@6763

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-ssr-query@6763

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@6763

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@6763

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@6763

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@6763

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-fn-stubs@6763

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@6763

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@6763

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@6763

@tanstack/start-storage-context

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@6763

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@6763

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@6763

@tanstack/vue-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router@6763

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router-devtools@6763

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router-ssr-query@6763

@tanstack/vue-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start@6763

@tanstack/vue-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start-client@6763

@tanstack/vue-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start-server@6763

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@6763

commit: fcfaec8

Copilot AI and others added 2 commits February 25, 2026 11:43

Initial plan

e503570

fix: sort manifest entries by key for stable build output in generate…

5afbccf

…ManifestModule Co-authored-by: motopods <58200641+motopods@users.noreply.github.com>

github-actions bot added the package: start-plugin-core label Feb 25, 2026

coderabbitai bot reviewed Feb 25, 2026

View reviewed changes

packages/start-plugin-core/src/start-compiler-plugin/plugin.ts Outdated Show resolved Hide resolved

schiller-manuel changed the title ~~Copilot/fix unstable server function manifest build output~~ fix: stabilize server function manifest build output Feb 26, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: stabilize server function manifest build output#6763

fix: stabilize server function manifest build output#6763
motopods wants to merge 3 commits intoTanStack:mainfrom
motopods:copilot/fix-unstable-build-output

motopods commented Feb 25, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Feb 25, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

schiller-manuel commented Feb 26, 2026

Uh oh!

nx-cloud bot commented Feb 26, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Feb 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

motopods commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

schiller-manuel commented Feb 26, 2026

Uh oh!

nx-cloud bot commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Feb 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

motopods commented Feb 25, 2026 •

edited

Loading

coderabbitai bot commented Feb 25, 2026 •

edited

Loading

nx-cloud bot commented Feb 26, 2026 •

edited

Loading