-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Enhance middleware documentation with error handling details #6499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Added explanation for error handling in middleware and provided an example of authentication middleware.
📝 WalkthroughWalkthroughAdded documentation explaining middleware error behavior: thrown errors default to a 500 with Error data; shows using Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@docs/start/framework/react/guide/middleware.md`:
- Line 82: Fix the typo "middlware" to "middleware" in the paragraph that reads
"If you want to return another error code, like with an authentication
middlware, you can throw the `json` helper." Locate the sentence in
docs/start/framework/react/guide/middleware.md (the line referencing throwing
the `json` helper) and correct the spelling to "authentication middleware".
- Around line 87-100: The TSX example has mismatched braces and a missing
closing parenthesis/semicolon causing unreachable code; update the
authMiddleware created by createMiddleware().server so the async callback
properly closes its if blocks and the server call: ensure the null-check for
client and the user-not-found json response both close their braces, then place
the return await next({ context: { user } }) inside the async function before
closing the server(...) call and terminate with the final `);` so the
authMiddleware, createMiddleware().server, and the async function scopes
(references: authMiddleware, createMiddleware().server, getMyDb, next, request)
are balanced and reachable.
Clarified error handling behavior in middleware documentation and updated code example to use await for asynchronous user retrieval.
Added explanation for error handling in middleware and provided an example of authentication middleware. I had to find this information from this discussion and not from the middleware documentation page:
#2887
Added:
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.