Skip to content

feat(devtools): extract theme to devtool components #2079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
harry-whorlow wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat(devtools): extract theme to devtool components #2079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/early-pandas-study.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@tanstack/solid-form-devtools': patch
'@tanstack/form-devtools': patch
'@tanstack/solid-form': patch
---

Moves devtools theme to the component to avoid theme miss-match.
2 changes: 1 addition & 1 deletion examples/solid/array/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
},
"dependencies": {
"@tanstack/solid-form": "^1.28.5",
"solid-js": "^1.9.9"
"solid-js": "^1.9.10"
},
"devDependencies": {
"typescript": "5.8.2",
Expand Down
2 changes: 1 addition & 1 deletion examples/solid/devtools/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"@tanstack/solid-devtools": "^0.7.7",
"@tanstack/solid-form": "^1.28.5",
"@tanstack/solid-form-devtools": "workspace:*",
"solid-js": "^1.9.9"
"solid-js": "^1.9.10"
},
"devDependencies": {
"typescript": "5.8.2",
Expand Down
2 changes: 1 addition & 1 deletion examples/solid/large-form/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
},
"dependencies": {
"@tanstack/solid-form": "^1.28.5",
"solid-js": "^1.9.9"
"solid-js": "^1.9.10"
},
"devDependencies": {
"typescript": "5.8.2",
Expand Down
2 changes: 1 addition & 1 deletion examples/solid/simple/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
},
"dependencies": {
"@tanstack/solid-form": "^1.28.5",
"solid-js": "^1.9.9"
"solid-js": "^1.9.10"
},
"devDependencies": {
"typescript": "5.8.2",
Expand Down
2 changes: 1 addition & 1 deletion examples/solid/standard-schema/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"effect": "^3.17.14",
"react": "^19.0.0",
"react-dom": "^19.0.0",
"solid-js": "^1.9.9",
"solid-js": "^1.9.10",
"valibot": "^1.1.0",
"zod": "^3.25.76"
},
Expand Down
4 changes: 2 additions & 2 deletions packages/form-devtools/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,12 +81,12 @@
},
"devDependencies": {
"rolldown-plugin-solid": "^0.2.1",
"solid-js": "^1.9.9",
"solid-js": "^1.9.10",
"tsdown": "^0.21.1",
"vite": "^7.2.2",
"vite-plugin-solid": "^2.11.8"
},
"peerDependencies": {
"solid-js": ">=1.9.9"
"solid-js": ">=1.9.10"
}
}
14 changes: 10 additions & 4 deletions packages/form-devtools/src/components/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,16 @@
import { ThemeContextProvider } from '@tanstack/devtools-ui'

import { FormEventClientProvider } from '../contexts/eventClientContext'
import { Shell } from './Shell'

export default function Devtools() {
import type { DevtoolProps } from '@tanstack/devtools-utils/solid'

export default function Devtools(props: DevtoolProps) {
return (
<FormEventClientProvider>
<Shell />
</FormEventClientProvider>
<ThemeContextProvider theme={props.theme}>
<FormEventClientProvider>
<Shell />
</FormEventClientProvider>
</ThemeContextProvider>
)
}
2 changes: 1 addition & 1 deletion packages/solid-form-devtools/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"build": "vite build"
},
"peerDependencies": {
"solid-js": ">=1.9.7"
"solid-js": ">=1.9.10"
},
"dependencies": {
"@tanstack/devtools-utils": "^0.3.2",
Expand Down
4 changes: 2 additions & 2 deletions packages/solid-form/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,11 @@
"@tanstack/solid-store": "^0.9.1"
},
"devDependencies": {
"solid-js": "^1.9.9",
"solid-js": "^1.9.10",
"vite": "^7.2.2",
"vite-plugin-solid": "^2.11.8"
},
"peerDependencies": {
"solid-js": ">=1.9.9"
"solid-js": ">=1.9.10"
}
}
254 changes: 135 additions & 119 deletions pnpm-lock.yaml
View file
Open in desktop

Large diffs are not rendered by default.

Loading