Update image sources for CodeRabbit and Cloudflare#1371
Update image sources for CodeRabbit and Cloudflare#1371santoshyadavdev wants to merge 1 commit intoTanStack:mainfrom
Conversation
|
📝 WalkthroughWalkthroughUpdated sponsor and partner logo image assets in README.md by changing CodeRabbit and Cloudflare logo URLs to new dark/light variant versions. No functional or behavioral changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@README.md`:
- Around line 76-78: The fallback <img> currently uses the white Cloudflare logo
which can be invisible on light backgrounds; update the <img> element's src to
use the black variant (the same URL used in the light <source> srcset) so the
fallback matches the light-mode default and ensure the height and alt attributes
remain unchanged; locate the <source media="(prefers-color-scheme: dark)">,
<source media="(prefers-color-scheme: light)"> and the <img src=...> tag in the
diff and replace the <img> src value accordingly.
| <source media="(prefers-color-scheme: dark)" srcset="https://tanstack.com/assets/cloudflare-white-Co-Tyjbl.svg" height="60" /> | ||
| <source media="(prefers-color-scheme: light)" srcset="https://tanstack.com/assets/cloudflare-black-6Ojsn8yh.svg" height="60" /> | ||
| <img src="https://tanstack.com/assets/cloudflare-white-Co-Tyjbl.svg" height="60" alt="Cloudflare" /> |
There was a problem hiding this comment.
Use a light-mode-safe fallback image for Cloudflare logo.
Line 78 currently falls back to the white logo, which can disappear on light backgrounds when <source> is not applied. Use the black variant as fallback to match the light-mode default.
Suggested fix
- <img src="https://tanstack.com/assets/cloudflare-white-Co-Tyjbl.svg" height="60" alt="Cloudflare" />
+ <img src="https://tanstack.com/assets/cloudflare-black-6Ojsn8yh.svg" height="60" alt="Cloudflare" />📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <source media="(prefers-color-scheme: dark)" srcset="https://tanstack.com/assets/cloudflare-white-Co-Tyjbl.svg" height="60" /> | |
| <source media="(prefers-color-scheme: light)" srcset="https://tanstack.com/assets/cloudflare-black-6Ojsn8yh.svg" height="60" /> | |
| <img src="https://tanstack.com/assets/cloudflare-white-Co-Tyjbl.svg" height="60" alt="Cloudflare" /> | |
| <source media="(prefers-color-scheme: dark)" srcset="https://tanstack.com/assets/cloudflare-white-Co-Tyjbl.svg" height="60" /> | |
| <source media="(prefers-color-scheme: light)" srcset="https://tanstack.com/assets/cloudflare-black-6Ojsn8yh.svg" height="60" /> | |
| <img src="https://tanstack.com/assets/cloudflare-black-6Ojsn8yh.svg" height="60" alt="Cloudflare" /> |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@README.md` around lines 76 - 78, The fallback <img> currently uses the white
Cloudflare logo which can be invisible on light backgrounds; update the <img>
element's src to use the black variant (the same URL used in the light <source>
srcset) so the fallback matches the light-mode default and ensure the height and
alt attributes remain unchanged; locate the <source
media="(prefers-color-scheme: dark)">, <source media="(prefers-color-scheme:
light)"> and the <img src=...> tag in the diff and replace the <img> src value
accordingly.
🎯 Changes
✅ Checklist
pnpm test.🚀 Release Impact
Summary by CodeRabbit