fix(db): prevent cross-query data contamination in useLiveInfiniteQuery #1214
+32
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using useLiveInfiniteQuery with syncMode: 'on-demand', navigating between different queries on the same collection causes the wrong data to appear on the first page. This happens because a new subscription's first snapshot reads from the local index, which may contain data loaded by a different subscription's loadSubset call. The fix tracks whether loadSubset has been called on a collection. When a new subscription's first snapshot runs: - If loadSubset has never been called, local data is from initial sync (valid for all queries) - If loadSubset has been called, local data may be contaminated, so we skip local reads and let loadSubset provide the correct data
🦋 Changeset detectedLatest commit: c2b7c80 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using useLiveInfiniteQuery with syncMode: 'on-demand', navigating between different queries on the same collection causes the wrong data to appear on the first page.
This happens because a new subscription's first snapshot reads from the local index, which may contain data loaded by a different subscription's loadSubset call.
The fix tracks whether loadSubset has been called on a collection. When a new subscription's first snapshot runs:
🎯 Changes
✅ Checklist
pnpm test:pr.🚀 Release Impact