Refactor / Request for Adoption #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* automatically load all deleted.files, no more copy'n'paste * add CLI component * simplify the whole interface * remove all unnessary cruft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Taggic,
I always found your plugin useful for cleaning up after manual updates, but it seems to be abandoned with #7 not being applied and thus rendering the plugin broken on modern PHP.
This PR is a major refactoring (close to a rewrite):
deleted.files(no need for copy'n'paste)It would be great if you could merge this. Alternatively if you are no longer interested in maintaining the plugin, I'd be open to adopt it at CosmoCode. If I don't hear back from you in a while, I will assume this plugin is abandoned per the DokuWiki Adoption Process.