Fix column type classification across all databases#462
Open
Fix column type classification across all databases#462
Conversation
Extract ColumnTypeClassifier from PluginDriverAdapter with dictionary-driven classification, wrapper stripping (Nullable/LowCardinality), and database-specific conventions (MySQL TINYINT(1), MSSQL BIT). Add ClickHouse Enum8/Enum16 value parsing and NTEXT long text support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ColumnTypeClassifierfromPluginDriverAdapterwith a dictionary-driven, three-phase pipeline: strip wrappers (Nullable/LowCardinality) → extract base type + params → classify via lookup + fallback patternsTINYINT(1)(now boolean),INT(11)/BIGINT(20)(now integer), MSSQLBIT(boolean),MONEY/SMALLMONEY(decimal),IMAGE/VARBINARY(N)(blob),DATETIME2/DATETIMEOFFSET/SMALLDATETIME(datetime), ClickHouseNullable()/LowCardinality()wrappers,Enum8/Enum16/DateTime64, DuckDB unsigned integers (UTINYINT,USMALLINT,UINTEGER,UBIGINT,HUGEINT)parseClickHouseEnumValuesforEnum8('a'=1,'b'=2)format and wire intofetchEnumValues()isLongTextto include MSSQLNTEXTCloses #461
Test plan
ColumnTypeClassifierTestspass (~100 test cases across MySQL, MSSQL, ClickHouse, DuckDB, PostgreSQL, SQLite, Oracle suites)ColumnTypeTestspass (existing 24 + 10 new tests for ClickHouse enum parsing and NTEXT)PluginDriverAdapterTableOpsTests,ColumnTypeBadgeLabelTests,CellDisplayFormatterTests)