fix(ai-chat): reset Copilot conversation when starting a new chat#1245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AIChatViewModel.startNewConversation()cleared the local UI state (messages, active id, error) but never toldCopilotChatProviderto drop its server-sideconversationId. The next message sent after "new conversation" was attached to the prior server-side conversation, so the AI's response was contaminated by the previous chat's context.switchConversation(to:)already callsAIProviderFactory.resetCopilotConversation().startNewConversation()was missing the same call.Fix
One line:
This covers all four entry points that reach
startNewConversation():/clearslash command/newslash commandhandleFixError(when an SQL error is forwarded to AI)UnifiedRightPanelView)Why only Copilot
Most providers (OpenAI, Anthropic direct, Gemini) are stateless from the API's perspective — TablePro sends the entire conversation history each turn, so clearing local
messagesis sufficient. Copilot is the exception: the claude.ai Code API stores the conversation server-side and we send only the new turn plus the cachedconversationId. That ID lives onCopilotChatProviderand survives across our local conversation boundaries unless we reset it.Test plan
Pre-fix repro:
Post-fix:
5. Model answers something like "I don't have any prior context."