Skip to content

fix(structure): inherit row emphasis propagation and deleted-row tint from DataGridRowView #1181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
datlechin wants to merge 3 commits into from
+10 −6
Closed

fix(structure): inherit row emphasis propagation and deleted-row tint from DataGridRowView #1181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0b4fc3
polish(ios): empty state actions and VoiceOver custom actions for swi…
datlechin May 10, 2026
87260c2
fix(structure): inherit row emphasis propagation and deleted-row tint…
datlechin May 10, 2026
4159d95
Merge branch 'main' into fix/structure-row-emphasis-propagation
datlechin May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion TablePro/Views/Results/DataGridRowView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import AppKit
import Combine

@MainActor
final class DataGridRowView: NSTableRowView {
class DataGridRowView: NSTableRowView {
weak var coordinator: TableViewCoordinator?
var rowIndex: Int = 0

Expand Down
14 changes: 9 additions & 5 deletions TablePro/Views/Structure/StructureRowViewWithMenu.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,17 @@

import AppKit

/// Row view providing a context menu tailored to the Structure tab
final class StructureRowViewWithMenu: NSTableRowView {
weak var coordinator: TableViewCoordinator?
var rowIndex: Int = 0
/// Row view providing a context menu tailored to the Structure tab.
/// Inherits selection/emphasis propagation, deleted-row tint, and layer-backing
/// from `DataGridRowView` so structure cells repaint on selection like data-tab cells.
final class StructureRowViewWithMenu: DataGridRowView {
var structureTab: StructureTab = .columns
var isStructureEditable: Bool = true
var isRowDeleted: Bool = false
var isRowDeleted: Bool = false {
didSet {
applyVisualState(RowVisualState(isDeleted: isRowDeleted, isInserted: false, modifiedColumns: []))
}
}
var referencedTableName: String?

var onCopyName: ((Set<Int>) -> Void)?
Expand Down
Loading