-
Notifications
You must be signed in to change notification settings - Fork 116
TYPO3 Core contribution wording #409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,18 +17,18 @@ Quick Start: Get ready to contribute to TYPO3 in under 30 minutes! | |
| Gitlab Merge Requests (MR) or GitHub Pull Requests (PR)**. | ||
| Once you set up GIT with your credentials (explained in these chapters), | ||
| you can directly push code to the `main` branch of TYPO3's own GIT. | ||
| Don't be afraid! You don't directly push "live code", but instead this | ||
| Don't be afraid! You don't directly :bash:`push` to "live code", but instead this | ||
| automatically triggers a workflow on our code review system | ||
| `Gerrit <https://review.typo3.org/>`_. This is where comments | ||
| are made, additional changes pushed (as ammended commits, with | ||
| are made, additional changes pushed (as amended commits, with | ||
| distinct "patch sets") and in the end merged by a member of the | ||
| Core team. | ||
| TYPO3 Core Team. | ||
|
|
||
| This `Tutorial` / `How To` will show you the easiest and | ||
| *quickest way to become a contributor* to TYPO3. | ||
| *quickest way to become a contributor* to TYPO3 Core. | ||
franzholz marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| It is aimed at developers who have a *good general knowledge*, | ||
| but need to know the *specifics and rules* of TYPO3 contributions. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the current "but" suits better. Lets keep it like that.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This line needs an explanation.
Is this easy introduction not for every TYPO3 developer? What are the specifics and rules? If this is not the easy document which is sufficient for every developer, where is it? |
||
| It is aimed at developers who have a *good general knowledge*. | ||
| They need to know the *specifics and rules* of TYPO3 contributions. | ||
|
|
||
| We will use *very brief wording* and only few "read further" hints to | ||
| *streamline the process* with conventions. Please check out the | ||
|
|
@@ -120,7 +120,7 @@ These are the sections: | |
|
|
||
| * **Install TYPO3** | ||
|
|
||
| * Enable **EXT:styleguide** | ||
| * Activate **EXT:styleguide** | ||
|
|
||
| * Launch **TYPO3 Backend** | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would make it more technical than I want here.
The "push" here is not really meant as a command but a concept. Otherwise it would also be "git push".
Lets keep this like currently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have always understood it as a
git pushcommand. What do you mean with concept for a push?