88 handle empty slc list#91
Merged
Merged
Conversation
Member
Author
|
Hi @Simon-van-Diepen this is the second PR for a JOSS feedback. mainly working on handling edge cases in |
|
Simon-van-Diepen
requested changes
May 19, 2026
Contributor
Simon-van-Diepen
left a comment
Simon-van-Diepen
left a comment
There was a problem hiding this comment.
Hi Ou,
I am uncertain about the removal of two parts of the code. Let's discuss
Simon-van-Diepen
approved these changes
May 20, 2026
Contributor
Simon-van-Diepen
left a comment
Simon-van-Diepen
left a comment
There was a problem hiding this comment.
After clarification I understand all these changes and they are good to go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #88
handled empty slc list
added more test for edge cases, mainly for metadata reading.