87 doc extra installtions#90
Conversation
|
Hi @Simon-van-Diepen, this is to fix a comment we get from the JOSS review. Could you please review this PR for me? thanks! |
Simon-van-Diepen
left a comment
Simon-van-Diepen
left a comment
There was a problem hiding this comment.
Just four minor comments, after that it's good to merge
|
|
||
| ```sh | ||
| pip install 'sarxarray[demo]' # to run the demo notebook | ||
| pip install 'sarxarray[dev]' # to run the test suite |
There was a problem hiding this comment.
| pip install 'sarxarray[dev]' # to run the test suite | |
| pip install 'sarxarray[dev]' # to run the test suite and enable code quality checks for developers |
There was a problem hiding this comment.
I think "run the test suite" already covers "enable code quality checks for developers". I will just keep it short here
There was a problem hiding this comment.
This makes it seem like the license is expired
There was a problem hiding this comment.
Indeed, I updated the liscense description.
Co-authored-by: Simon-van-Diepen <44979564+Simon-van-Diepen@users.noreply.github.com>
|
Thanks @Simon-van-Diepen! I plan to merge this tomorrow. Feel free to have a last look if you want. |
|
2 participants
Fix #87
Updated both README and docs installation page.