-
Notifications
You must be signed in to change notification settings - Fork 5
Joss paper #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Joss paper #62
Conversation
|
Hi @SarahAlidoost and @FreekvanLeijen, I drafted a JOSS paper for SARXarray according to this guideline. I put both of you as authors of this paper since you both have significant contribution in the concept and implementation. When you have time, can you review this draft? You can find a rendered paper in the artifact of the github workflow. |
SarahAlidoost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rogerkuou thanks for preparing the draft. I left some comments, please let me know if something is unclear.
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
|
|
Hi @SarahAlidoost, thanks for reviewing the JOSS paper and apoligies for only reacting till now. Can I adapted all your suggestions. Can you give another look? |
FreekvanLeijen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Ou, nice story! I inserted some adaptions. Please have a look.
Co-authored-by: FreekvanLeijen <f.j.vanleijen@tudelft.nl>
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
Co-authored-by: FreekvanLeijen <f.j.vanleijen@tudelft.nl>
|
|
Hi @FreekvanLeijen, I adapted all of your comments. Thanks for the review! Can you give a final look? BTW I closed and reopened this PR for a correct rendering of the changed files. |



Joss paper