12-responses-api #83
Open
12-responses-api #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor client extraction from pydantic model into util function
Need to set model_info.id for the default chat model in example_router_config.yaml to create openai client
…o which represents the whole usage) Add streaming responses tests
Add response "lifecycle" test code
Make the basic responses test use async client to fix debugging bug in pycharm
# Conflicts: # aqueduct/gateway/tests/test_image_generation.py # aqueduct/gateway/views/decorators.py # aqueduct/gateway/views/image_generation.py
4 tasks
Making mocks work again after oai_client_from_body refactor Remove old vllm test utils
natkam
reviewed
Dec 5, 2025
Contributor
natkam
left a comment
natkam
left a comment
There was a problem hiding this comment.
I haven't reviewed everything, but I have a few nit-picks already. But let's talk about this feature next week!
natkam
approved these changes
Dec 11, 2025
Contributor
natkam
left a comment
natkam
left a comment
There was a problem hiding this comment.
Looks good! And thanks for the docstrings, they are exactly what I wanted!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.